Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for automatic light/dark mode from system theme #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thatcomputerguy0101
Copy link

@thatcomputerguy0101 thatcomputerguy0101 commented Jun 29, 2024

This adds an option for a "system" theme that will pull the light or dark mode setting from the browser in CSS. Currently this duplicates the dark mode styles, but could be modified in the future to use the light-dark function and remove style duplication once browser support is no longer a concern.

The new system theme will be the default for new installs, but existing installs will maintain their current theme setting.

@thatcomputerguy0101
Copy link
Author

This would fulfill #67.

@thatcomputerguy0101
Copy link
Author

Additionally, the new menu option will need to be added to most of the localization tables.

@ossilator
Copy link

i don't believe that that package-lock.json file belongs into the commit. please amend and force-push.

note also the pinned issues.

@thatcomputerguy0101
Copy link
Author

thatcomputerguy0101 commented Jun 30, 2024

I've fixed the package-lock.json file. You might want to add that to the .gitignore file if you don't want it tracked.

@thatcomputerguy0101
Copy link
Author

By the pinned issues, I'm assuming you are referencing the lack of continued support with the Manifest v3 changes?

@ossilator
Copy link

correct.

@MatheusRich
Copy link

I understand the projects is essentially going to die. But can we get this merged before that? It seems that we can keep using this as-is at least until Jun 2025?

@Technetium1
Copy link

I agree, merging would be good even if it doesn't get put into a release, assuming it's been tested.

@gioxx
Copy link
Owner

gioxx commented Sep 3, 2024

The main reason we no longer released intermediate versions of TMS on the Chrome Store is that the extension is completely incompatible with Google Chrome's (no longer so new) tab grouping system. Releasing an update would mean breaking all tab grouping for all users who use TMS, because TMS is still unable to talk properly with that system (and it's not even certain that it really can be even by switching to Manifest V3), effectively making it a problem instead of an ally.

@gioxx gioxx self-assigned this Sep 3, 2024
@user334 user334 mentioned this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants