Skip to content

Commit

Permalink
Merge pull request #26 from girvo/fixing-vhost
Browse files Browse the repository at this point in the history
Fixes incorrect default VIRTUAL_HOST variable
  • Loading branch information
girvo authored Nov 23, 2016
2 parents d93c71a + 4284ed0 commit d9211f7
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## v1.0.4

- Fixes incorrect `VIRTUAL_HOST` env-var for the web-container when using the default

## v1.0.3

- Removes the bindings between `VIRTUAL_HOST` and `hostname` (`-h` in the `docker run`) for the web container. This fixes the incorrect hostname format when a composite `VIRTUAL_HOST` is passed in via `env`
Expand Down
2 changes: 1 addition & 1 deletion dup.nimble
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[Package]
name = "dup"
version = "1.0.3"
version = "1.0.4"
author = "Josh Girvin <[email protected]>, Nathan Craike <[email protected]>"
description = "CLI wrapper for local Docker web development"
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion src/container.nim
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ proc startWebCmd*(conf: ProjectConfig, hasDb: bool = true): string {.raises: [],
folder = "-v $PWD/code:/var/www"
var vhostEnv = ""
if vhost == "":
vhostEnv = "-e VIRTUAL_HOST=" & quoteShellPosix(vhost)
vhostEnv = "-e VIRTUAL_HOST=" & quoteShellPosix(hostname)

result = join([
"docker run",
Expand Down
2 changes: 1 addition & 1 deletion src/dup.nim
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ from database import newDBConfig
from container import checkDockerfile, checkAndParseDupFile

## Define our version constant for re-use
const version = "dup 1.0.3"
const version = "dup 1.0.4"

## Define our docopt parsing schema
let doc = """
Expand Down

0 comments on commit d9211f7

Please sign in to comment.