Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff: Stricter linting rules #20

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Ruff: Stricter linting rules #20

merged 6 commits into from
Jul 4, 2023

Conversation

tony
Copy link
Member

@tony tony commented Jul 4, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Merging #20 (3fd4998) into master (b432c92) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   59.56%   59.53%   -0.03%     
==========================================
  Files          10       10              
  Lines         648      650       +2     
==========================================
+ Hits          386      387       +1     
- Misses        262      263       +1     
Impacted Files Coverage Δ
tests/conftest.py 94.73% <ø> (+2.63%) ⬆️
tests/test_linkify_issues.py 94.73% <ø> (ø)
src/doctest_docutils.py 37.33% <18.18%> (-0.27%) ⬇️
docs/conf.py 56.86% <20.00%> (-1.73%) ⬇️
src/pytest_doctest_docutils.py 39.00% <50.00%> (-1.78%) ⬇️
tests/test_doctest_docutils.py 94.73% <60.00%> (-2.41%) ⬇️
tests/test_pytest_doctest_docutils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

tony added 3 commits July 4, 2023 13:19
src/doctest_docutils.py:137:31: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
src/doctest_docutils.py:141:31: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
src/doctest_docutils.py:145:31: RUF012 Mutable class attributes should be annotated with `typing.ClassVar`
src/doctest_docutils.py:398:15: TRY003 Avoid specifying long messages outside the exception class
src/doctest_docutils.py:408:16: PTH119 `os.path.basename()` should be replaced by `Path.name`
tests/test_doctest_docutils.py:206:15: TRY003 Avoid specifying long messages outside the exception class
@tony tony merged commit dcb995a into master Jul 4, 2023
9 checks passed
@tony tony deleted the ruff-rules branch July 4, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants