Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive.md: Update About Rev News link #547

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

PhilipOakley
Copy link
Contributor

The current About Rev News link results in a 404.
Link direct to the git.github.io page.

Fixes one point in #545

Signed-off-by: Philip Oakley [email protected]

The current `About Rev News` link results in a 404.
Link direct to the git.github.io page.

Fixes one point in git#545 

Signed-off-by: Philip Oakley [email protected]
@mjaix mjaix merged commit 94afd35 into git:master Feb 1, 2022
@mjaix
Copy link
Contributor

mjaix commented Feb 1, 2022

Thanks a lot for finding just another relative link!

@PhilipOakley
Copy link
Contributor Author

Thanks. I forgot to point out that the error I saw was when I navigated, on GitHub, within the repo to the archive.md file (i.e. here https://github.com/git/git.github.io/blob/master/rev_news/archive.md).

As it is a markdown file, GitHub renders it and showed the hyperlink. It was clicking on that hyperlink that failed, rather than me checking the gh pages at https://git.github.io/

In retrospect I'm not so sure that my change is the right one as I changed from (apparently) a relative link, to an absolute link. It maybe a relative link could still be used, but with some 'corrected' path. Also there are two "About" pages in the https://git.github.io/ pages, one of which is https://git.github.io/rev_news/rev_news/

I suspect most of the #545 comments are about that confusion between starting at the 'gh pages' vs starting at the repo' markdown.md pages.

@sivaraam
Copy link
Member

sivaraam commented Feb 9, 2022

Also there are two "About" pages in the https://git.github.io/ pages, one of which is https://git.github.io/rev_news/rev_news/

Precisely, I believe linking to https://git.github.io/rev_news/rev_news/ would be more appropriate as the link promises to give information about subscribing which https://git.github.io/about does not provide directly. The "About Git Developer Pages" does have a link to the "About Git Rev News" page but that's likely a roundabout way to get the information about subscribing to the newsletter.

It maybe a relative link could still be used, but with some 'corrected' path.

I couldn't immediately think of a some 'corrected' path that would work in both GitHub's Markdown rendering and the rendered site. But I suppose, we don't expect too many people to read the pages of the site via GitHub. So, it might be much of a problem having links that don't work on GitHub. OTOH, we do seem to use absolute links a lot (in rev news posts, about page). So, it might be fine to have absolute links too.

I suppose if there's one change to do now, it would be to change the absolute link in archive.md from https://git.github.io/about/ to https://git.github.io/rev_news/rev_news/ 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants