Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gitar] Cleaning up stale flag: is-dark-mode-enabled with value true #110

Closed

Conversation

gitar-bot-staging[bot]
Copy link

Gitar
This automated PR permanently enables the is-dark-mode-enabled feature flag.

Summary of Changes

Gitar found and removed uses of the is-dark-mode-enabled feature flag across 3 files:

  • launchdarkly/dart/sample.dart
  • launchdarkly/java/Sample.java
  • launchdarkly/java/SampleDeep.java

Gitar performed deep cleanup and code optimizations triggered by the feature flag removal in 2 of these files.

Code Cleanup Details
  • launchdarkly/dart/sample.dart

    • Replaced Feature Flag Usage
  • launchdarkly/java/Sample.java

    • Replaced Feature Flag Usage
    • Cleaned up code (5 times)
      • Deleted the unused local variable client
      • Deleted the unused local variable context
      • Deleted the unused local variable flagValue
      • Propagated the value true to uses of the local variable flagValue
      • Simplified control flow
  • launchdarkly/java/SampleDeep.java

    • Replaced Feature Flag Usage
    • Cleaned up code (7 times)
      • Deleted the unused local variable flagValue
      • Deleted the unused private function forceDarkModeFromLocalConfig
      • Deleted the unused private function isDarkModeEnabled
      • Propagated the value true to uses of the function isDarkModeEnabled
      • Propagated the value true to uses of the local variable flagValue
      • Simplified control flow
      • Simplified boolean expressions
Details

Triggered via #105 (comment) by @donald-pinckney


This automated PR was generated by Gitar. View docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant