Use focus manager for navigation context menus #10430
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mtsgrd
force-pushed
the
context-menu-nav
branch
from
629007b to
5c72e1d
Compare
output.mp4@PavelLaptev could you have a look at this and let me know what you think? *edit: still need to fix tab for moving to next/prev item. |
|
@mtsgrd thanks for tagging. Looks nice, but let’s keep only one outline instead of two. 
I think the inner one should stay since we use the arrow to navigate. |
|
To me it looks like I included a change with |
@mtsgrd sorry, I was looking at the video you attached. |
|
@mtsgrd how can I trigger the context menu using the keyboard? I tried the "Enter" key but it didn’t open it. Screen.Recording.2025-09-24.at.12.51.34.mov |
|
I'll investigate! |
mtsgrd
force-pushed
the
context-menu-nav
branch
from
5c72e1d to
5dbc5c3
Compare
|
Ok, should be fixed. I added enter key handling to KebabButton.svelte. |
|
Thanks! Looks like it works for branches but not for commits Screen.Recording.2025-09-24.at.13.16.42.mov |
Removes custom keyboard navigation for context menus, and replaces it with the new focus manager functionality. Note that ContextMenuItem contains two focusables, one for navigation and one to support f-keys.
mtsgrd
force-pushed
the
context-menu-nav
branch
from
5dbc5c3 to
c3108b4
Compare
|
@PavelLaptev just fyi, I still intend to land something like this but I'm currently trying to work through an inconsistency between Chrome and Safari wrt to |
Gotcha! Let me know if you need me to test anything or if you need any help :-) |
Removes custom keyboard navigation for context menus, and replaces it
with the new focus manager functionality. Note that ContextMenuItem
contains two focusables, one for navigation and one to support f-keys.