Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change postinstall for prepare script #6

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

0xnigir1
Copy link
Collaborator

Motivation and Context

When installing this package directly from GitHub, it needs to be built during installation. Right now, this uses a postinstall script, but devDependencies (e.g., tsc from typsecript) aren’t installed, causing the build to fail. The correct approach is to use a prepare script, as it ensures devDependencies are installed too and the script runs before packaging and installation.

Taken from npm Docs:

NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed.

References:
scripts | npm Docs

Changes

  • change postinstall for prepare script in package.json

@0xnigir1 0xnigir1 self-assigned this Nov 25, 2024
@0xnigir1 0xnigir1 merged commit f7692a2 into fix-max-status-value Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants