Fix candidate runner hook filename - #68
Conversation
GitHub Runner requires job-started hooks to use a supported script extension. Rename the constrained Phase 2 hook to .sh and preserve the enforcement test. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joseph Yaksich <gitcommit90@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe runner start hook now uses a root-owned shell script that validates the authorized workflow context. The systemd override and Phase 2 candidate test use and verify the ChangesRunner hook validation and wiring
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant RunnerService
participant runner-job-started.sh
participant WorkflowEventPayload
RunnerService->>runner-job-started.sh: invoke job-start hook
runner-job-started.sh->>WorkflowEventPayload: read workflow_run JSON
WorkflowEventPayload-->>runner-job-started.sh: return event context
runner-job-started.sh-->>RunnerService: allow or reject execution
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Use one unlink invocation per fixed candidate payload and keep a regression assertion for the root boundary. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Joseph Yaksich <gitcommit90@users.noreply.github.com>
Fix
GitHub Runner only accepts job-started hooks with a supported script extension. Rename the constrained Phase 2 hook to
.sh, update its service path, and retain enforcement coverage.Verification
🤖 Generated with Claude Code
Summary by CodeRabbit
Security
Reliability