Skip to content

Fix Cargo.lock and add check to ensure the working tree remains clean after build #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qmonnet merged 2 commits into from
Jun 24, 2026
Merged

Fix Cargo.lock and add check to ensure the working tree remains clean after build #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4099e
chore: Update version for dataplane-acl in Cargo.lock
qmonnet Jun 19, 2026
8e96921
ci: Add check to ensure the working tree remains clean after build
qmonnet Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,21 @@ jobs:
with:
recipe: "doctest"

- &verify-clean-tree
name: "verify-clean-tree"
run: |
set -euo pipefail
if [ -n "$(git status --porcelain)" ]; then
echo "::error:: Building the project left the tree dirty."
echo "----- git status --porcelain -----"
git status --porcelain
echo "----- git diff -----"
git diff
echo "----- hint -----"
echo "If the diff is on Cargo.lock, run a build locally and commit the updated lock file."
exit 1
fi
Comment thread
qmonnet marked this conversation as resolved.
Resolved

- &tmate
name: "Setup tmate session for debug"
if: "${{ failure() && github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}"
Expand Down Expand Up @@ -257,6 +272,7 @@ jobs:
)
just "${base_args[@]}" push-container "${NIX_TARGET}"
just "${base_args[@]}" "version=${VERSION}-${PROFILE}" push-container "${NIX_TARGET}"
- *verify-clean-tree
- *tmate

sanitize:
Expand Down
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading