Repository navigation
test(nat): Remove warning for shuttle tests - #1617
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthrough
ChangesTest helper lint suppression
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qmonnet
force-pushed
the
pr/qmonnet/warning-shuttle
branch
from
July 6, 2026 11:18
557fa3c to
1615488
Compare
Fredi-raspall
approved these changes
Jul 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 6, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 7, 2026
We have a warning when building the shuttle tests for nat:
$ cargo check --features shuttle --all-targets -p dataplane-nat
[...]
warning: function `vpcd1` is never used
--> nat/src/masquerade/apalloc/test_alloc.rs:43:12
|
43 | pub fn vpcd1() -> VpcDiscriminant {
| ^^^^^
|
= note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
It's not blocking, but let's suppress it anyway.
On Copilot review's suggestion, suppress "dead_code" warnings rather
than "unused", that might be broader (such as unused variables or
imports inside of body functions).
Signed-off-by: Quentin Monnet <qmo@qmon.net>
qmonnet
force-pushed
the
pr/qmonnet/warning-shuttle
branch
from
July 8, 2026 08:13
1615488 to
cd11e47
Compare
qmonnet
enabled auto-merge
July 8, 2026 08:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a warning when building the shuttle tests for nat:
It's not blocking, but let's suppress it anyway.