Repository navigation
chore(env-ci-1): new style gateway interfaces - #31
Merged
Merged
Conversation
Gateway VM NICs except the management one are on the root bus now (githedgehog/fabricator#2175), so the passthrough NIC is port1 at 0000:00:10.0 with the kernel driver. Signed-off-by: Sergei Lukianov <me@slukjanov.name>
There was a problem hiding this comment.
🔵 Needs a closer look
The explicitly breaking dependency on githedgehog/fabricator#2175 requires coordinated merges to avoid disrupting the hardware lab.
No open issues 🎉
What changed in this PR
Updates the env-ci-1 gateway configuration to match the root-bus NIC layout introduced by githedgehog/fabricator#2175.
Changes:
- Sets both gateways to use the kernel driver.
- Defines logical interface
port1with PCI address0000:00:10.0and the corresponding kernel interface name. - Updates gateway connection references to use
port1.
| File | Description |
|---|---|
envs/env-ci-1.l/wiring-gateway.yaml |
Migrates both gateway interface definitions and connection references to the new NIC layout. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway VM NICs except the management one are on the root bus now (githedgehog/fabricator#2175), so the passthrough NIC of the env-ci-1 gateways is
port1at0000:00:10.0(enp0s16np0/enp0s16np1) with the kernel driver.Merge together with githedgehog/fabricator#2175: it breaks hlab with the current fabricator master, and hlab breaks without it once githedgehog/fabricator#2175 is merged.