feat: use dynamodb instead of ssm for JIT config #4446
+3,457
−2,105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
id
force-pushed
the
use-dynamodb-ephemeral-multi-arch-prebuilt-example
branch
2 times, most recently
from
f3d5721 to
89cac18
Compare
Add extra capabilities to support ephemeral multiarch runners. In workflow jobs with large matrix, github can request large number of runners simultaneously. This can cause the ssm to be overwhelmed. This PR replaces the ssm with dynamodb to store the JIT config. Also fixed a couple things: - `runners_ssm_housekeeper` schema was not aligned across modules - syntax for `env` in `github_agent.ubuntu.pkr.hcl` Added a couple of improvements: - updated baseline provisioning script for prebuilt runners to make it closer to what github hosted runners do - startup-runner.sh now automatically discovers attached ebs volume and mounts it to /data
id
force-pushed
the
use-dynamodb-ephemeral-multi-arch-prebuilt-example
branch
from
1711979 to
16a67b8
Compare
|
@id thanks for creating the PR. It is abit one so need to find some time to review. I see you also added a lambda for cleaning up github left overs. Would it be possible to split this in a sperate PR? Would help the review and testing part. Are you on our discord server? Maybe a short chat about some question is quicker when I go over the code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extra capabilities to support ephemeral multiarch runners.
In workflow jobs with large matrix, github can request large number of runners simultaneously. This can cause the ssm to be overwhelmed.
This PR replaces the ssm with dynamodb to store the JIT config.
Also fixed a couple things:
runners_ssm_housekeeperschema was not aligned across modulesenvingithub_agent.ubuntu.pkr.hclAdded a couple of improvements:
startup-runner.shnow automatically discovers attached ebs volume, mounts it to/data, and points root directory for docker and containerd daemons to/data/dockerand/data/containerdrespectively.