-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fixed markdown #4366
base: master
Are you sure you want to change the base?
Fixed markdown #4366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @justinachua,
Congrats on graduating! 🎓 🎉
You haven't added your information! 🙅 You need to have the following 2 files:
- A markdown file
- A profile image
Although you do have the markdown file, it's empty. Please read instructions on the README file for more information.
Unfortunately, the image is not squared (1:1 or width = height) 🔳 The size of the image is 3004x3008 (pixels).
Lastly, the checklist hasn't been marked properly. We cannot add your information to the yearbook without your permission. You can edit your comment and mark the task list by changing [ ]
to [x]
(without spaces). Please refer here for more information.
Could you please make these changes? 📝
Thanks,
Mohammed Shoaib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have reviewed 📝 your application to the yearbook. It looks great ✨ but we found that some headers might be missing in the Markdown file or the format is broken (used any non-ascii characters?). I will close this PR so you can do the changes requested. You can open a new one once you've done the fixes and we will review it again.😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need you to add the content on the markdown file before accepting your pull request
Application to the Class of 2020🎓
This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.
Checklist ✅
_data
folder and followed the naming convention mentioned in the instructions (<username>
), added my profile picture and markdown file.