Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

could it be pageable for searching #562

Open
ghost opened this issue May 6, 2019 · 3 comments · May be fixed by #596
Open

could it be pageable for searching #562

ghost opened this issue May 6, 2019 · 3 comments · May be fixed by #596
Assignees
@j-rewerts
Labels
enhancement needs tests PRs welcome

Comments

@ghost
Copy link

ghost commented May 6, 2019

#367
it is slow due to search for all items ,
@j-rewerts
Copy link
Member

Yeah makes sense. It looks like we call the Requestable._requestAllPages function. If we used this function, you could pass through a page token as an option.

I'm open to a PR!

@j-rewerts
Copy link
Member

@WJXHenry, @kylejeske Let me know if you want to take this on.

@WJXHenry
Copy link
Contributor

WJXHenry commented May 7, 2019

@j-rewerts Sure, I'll be happy to take this on!

@j-rewerts j-rewerts mentioned this issue Aug 25, 2019
Open
@j-rewerts j-rewerts self-assigned this Oct 21, 2019
@j-rewerts j-rewerts linked a pull request Oct 24, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j-rewerts j-rewerts

Labels
enhancement needs tests PRs welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Search paging j-rewerts/github
2 participants
@j-rewerts @WJXHenry