Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Search paging #596

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP: Search paging #596

wants to merge 5 commits into from

Conversation

j-rewerts
Copy link
Member

Added optional manual paging of search. Closes #562.

@j-rewerts
Copy link
Member Author

@DanielRuf I'm running into some issue with Nock I just can't seem to sort out. When I run the search tests on their own, my new test passes. If I run all tests using npm run test, my new test fails. Any idea why this may be happening?

@j-rewerts j-rewerts requested a review from DanielRuf October 30, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf Awaiting requested review from DanielRuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

could it be pageable for searching
1 participant
@j-rewerts