Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add label to an issue #461

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

asmsuechan
Copy link

I could not find these methods so I created. If anyone has any information about them, please let me know.

@asmsuechan asmsuechan force-pushed the add-add-label-to-an-issue branch from 4fbc7bd to 81706ba Compare July 11, 2017 12:32
Copy link
Member

@mtscout6 mtscout6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for these.

@asmsuechan
Copy link
Author

Sure

@j-rewerts
Copy link
Member

@clayreimann This API is marked as preview by GitHub. What is the policy on using preview APIs?

@clayreimann
Copy link
Member

@j-rewerts it's unclear. I guess we could mark the API as provisional in this library and let clients assume the risks

@j-rewerts
Copy link
Member

Yeah that's a good idea. I'll take this code and write tests for them when I have a second. I've added an issue here for going through the code base and adding warnings like this.

@clayreimann
Copy link
Member

Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants