[GHSA-cwvm-v4w8-q58c] Blind local file inclusion

[EliahKagan]

Updates

• Affected products

Comments
The fix in GitPython 3.1.35 was incomplete, as discussed in gitpython-developers/GitPython#1672. A new release, https://github.com/gitpython-developers/GitPython/releases/tag/3.1.37, includes a proper fix. The maintainer has updated the advisory associated with the repository, GHSA-cwvm-v4w8-q58c, to indicate that the fully patched version is 3.1.37 instead of any earlier version.

This change proposes the corresponding change in the GitHub Advisory Database, which would make both advisories convey the same, up-to-date information. The maintainer of GitPython, @Byron, has requested that this be done (gitpython-developers/GitPython#1672 (comment), gitpython-developers/GitPython#1672 (comment)).

This is based on a preference, in this case, to update the existing advisory and not to create a new one (as noted in the linked comments above). However, if this change to the advisory would not be sufficient to raise Dependabot alerts, that may be relevant.

[github]

Hi there @stsewd and @Byron! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our highly-trained Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

[Byron]

Thanks a lot for your help, much appreciated!

[taladrane]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.

[EliahKagan]

I'm hoping this can still be reviewed by a member of the Security Curation Team.

• If it can be merged, then that would update GitHub's global advisory database to include the version that really fixes the bug, which I think may result in automated tools such as Dependabot can notify users of the update (maybe a reviewer can speak to this).
• If for any reason that is considered not to be feasible or appropriate, then alternatives can be explored, as noted in the description in this PR (see discussion in Add more checks for the validity of refnames gitpython-developers/GitPython#1672 for full context).

[darakian]

Apologies on the delay. Getting to this now 🙇

[advisory-database]

Hi @EliahKagan! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!