[GHSA-rc7v-65v6-m2v3] go-mysql affected by go.uuid's Predictable UUID Identifiers #4990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Comments
I would like to suggest this advisory to be withdrawn, as I do not believe that CVE-2021-3538 affects any version of github.com/go-mysql-org/go-mysql.
The advisory for CVE-2021-3538 makes it clear that the vulnerability only affects the commits 0ef6afb2f6cdd6cdaeee3885a95099c63f18fc8c to d91630c8510268e75203009fe7daf2b8e1d60c45. It also mentions that this range of commits was never in a tagged release of satori/go.uuid.
Now, comparing the tags 1.4.0 and 1.5.0 in github.com/go-mysql-org/go-mysql we can see the commit that replaced github.com/satori/go.uuid with github.com/google/uuid. Looking at the
go.mod
file between versions, we can see that the version of github.com/satori/go.uuid used was 1.2.0, which is completely safe and not vulnerable to CVE-2021-3538. Searching previous versions ofgo.mod
I cannot find any other versions of github.com/satori/go.uuid. Because of this, I have reason to believe that github.com/go-mysql-org/go-mysql was never using a vulnerable version of github.com/satori/go.uuid.