Skip to content

docs(refactor-plan): expand skill description and instructions#1673

Closed
jrkasprzyk wants to merge 2 commits into
github:stagedfrom
jrkasprzyk:refactor-plan-skill-description
Closed

docs(refactor-plan): expand skill description and instructions#1673
jrkasprzyk wants to merge 2 commits into
github:stagedfrom
jrkasprzyk:refactor-plan-skill-description

Conversation

@jrkasprzyk
Copy link
Copy Markdown
Contributor

Summary

  • Expand the refactor-plan skill description so agents know when to invoke it (plan/sequence/scope a multi-file refactor) and that planning must precede edits.
  • Rewrite SKILL.md instructions: investigate first without editing, plan contracts → impl → callers → tests → cleanup, include verification + rollback, and stop for confirmation before Phase 1.
  • Sync the updated description into docs/README.skills.md so the catalog row matches the skill frontmatter.

Why

The prior one-line description ("Plan a multi-file refactor with proper sequencing and rollback steps") gave no invocation signal and did not prevent agents from starting edits while "planning." The new copy makes the skill discoverable by intent and enforces a plan-first, confirm-before-edit workflow.

Test plan

  • Verify the docs/README.skills.md row matches skills/refactor-plan/SKILL.md frontmatter description
  • Trigger the skill with a sample multi-file refactor request and confirm it outputs the plan and waits for confirmation
  • Confirm no code files are edited during the plan phase

github-actions Bot and others added 2 commits May 11, 2026 03:41
  Clarify when to invoke the skill and require a plan-first,
  confirm-before-edit workflow so agents do not start changing
  files during planning.
Copilot AI review requested due to automatic review settings May 11, 2026 16:24
@jrkasprzyk jrkasprzyk requested a review from aaronpowell as a code owner May 11, 2026 16:24
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR targets main, but PRs should target staged.

The main branch is auto-published from staged and should not receive direct PRs.
Please close this PR and re-open it against the staged branch.

You can change the base branch using the Edit button at the top of this PR,
or run: gh pr edit 1673 --base staged

@github-actions github-actions Bot added skills PR touches skills targets-main PR targets main instead of staged labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔴 Contributor Reputation Check: HIGH risk

Check Risk
Profile HIGH
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

@github-actions github-actions Bot added the needs-review:HIGH Contributor reputation check flagged HIGH risk label May 11, 2026
@jrkasprzyk jrkasprzyk changed the base branch from main to staged May 11, 2026 16:26
@jrkasprzyk jrkasprzyk requested a review from dvelton as a code owner May 11, 2026 16:26
@github-actions github-actions Bot added branched-main PR appears to include plugin files materialized from main and removed skills PR touches skills targets-main PR targets main instead of staged labels May 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔴 Contributor Reputation Check: HIGH risk

Check Risk
Profile HIGH
Credential audit NONE

Maintainers: please review this contributor before merging.
See the workflow run for full details.
Automated check powered by AGT.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@jrkasprzyk
Copy link
Copy Markdown
Contributor Author

There's a line ending problem or something, sorry! I'll fix and try again later.

@jrkasprzyk jrkasprzyk closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branched-main PR appears to include plugin files materialized from main needs-review:HIGH Contributor reputation check flagged HIGH risk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants