Log result of validateWorkflow if not undefined
#2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
previously approved these changes
Nov 12, 2024
mbg
force-pushed
the
mbg/fix/validateWorkflowResult
branch
from
cef87ae
to
58f2dfc
Compare
|
@aeisenberg I rebased to resolve a merge conflict in the generated files, otherwise there's no change. |
aeisenberg
approved these changes
Nov 14, 2024
This was referenced Nov 19, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
validateWorkflowreturns something other thanundefined, the result is discarded. For example, if an error occurs while validating the workflow, there is currently no output in the workflow log to indicate that. This PR fixes this by logging any non-undefinedresult fromvalidateWorkflowas a warning.Merge / deployment checklist