This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Non-alert queries #531
Merged
Non-alert queries #531
+1,608
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
force-pushed
the
non-alert-queries
branch
from
ae10b61 to
9d74394
Compare
smowton
reviewed
Apr 26, 2021
| @@ -0,0 +1 @@ | |||
| ERROR: Diagnostic must implement toString() (/home/sauyon/devel/semmlego/ql/src/Diagnostics/DiagnosticsReporting.qll:6,15-25) | |||
There was a problem hiding this comment.
This doesn't look expected?
sauyon
force-pushed
the
non-alert-queries
branch
2 times, most recently
from
a70819c to
e42cf7c
Compare
smowton
approved these changes
Apr 26, 2021
sauyon
force-pushed
the
non-alert-queries
branch
from
53ae134 to
4b938fe
Compare
added 8 commits
April 27, 2021 01:18
smowton
approved these changes
Apr 27, 2021
smowton
force-pushed
the
non-alert-queries
branch
from
4b938fe to
ceb9d62
Compare
|
Rebased and set to automerge |
|
@sauyon are the test changes as you'd expect? |
|
Yep, let me rebase again... |
sauyon
force-pushed
the
non-alert-queries
branch
from
ceb9d62 to
bfe6e75
Compare
|
Had to evaluate symlinks for the other PR; this should hopefully work... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was being rather silly; Go gives very good errors about what exactly has gone wrong, and the cases where errors don't have locations are probably much more rare than I thought.
EDIT: More tests on the way, but I'm reworking the test script, so that might take a bit more time.