Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS: have getId always return null if skipExtractingTypes is set #17831

Merged
merged 1 commit into from
Oct 24, 2024
Merged

JS: have getId always return null if skipExtractingTypes is set #17831

merged 1 commit into from
Oct 24, 2024
+1 −0

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Oct 23, 2024 •
edited
Loading

Fixes the hang reported in #17827 (if you disable type extraction)

@github-actions github-actions bot added the JS label Oct 23, 2024
@erik-krogh erik-krogh marked this pull request as ready for review October 23, 2024 16:14
@erik-krogh erik-krogh requested a review from a team as a code owner October 23, 2024 16:14
@asgerf
Copy link
Contributor

asgerf commented Oct 24, 2024

Maybe run DCA first?

@erik-krogh
Copy link
Contributor Author

Evaluation look good.
The evaluation was very uneventful.
I forced the skipExtractingTypes flag to be true, and evaluated before/after this PR.

I took a look at the extraction time for VSCode, and it looks like a minor improvement.

@erik-krogh erik-krogh merged commit 7bbd4a1 into github:main Oct 24, 2024
7 checks passed
@erik-krogh erik-krogh mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf asgerf approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erik-krogh @asgerf