Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#: Traced-mode integration tests for Blazor #18440

Conversation

egregius313
Copy link
Contributor

Copy of #18325 except with the build-mode: none test removed.

If #18325 still has issues with build-mode: none, then this can be merged and unblock adding the integration tests.

@egregius313 egregius313 added the no-change-note-required This PR does not need a change note label Jan 8, 2025
@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 04:03
@egregius313 egregius313 requested a review from a team as a code owner January 8, 2025 04:03
@github-actions github-actions bot added the C# label Jan 8, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 35 out of 50 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/BlazorTest.csproj: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/MainLayout.razor.css: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/NavMenu.razor.css: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Properties/launchSettings.json: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/appsettings.json: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/global.json: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/wwwroot/app.css: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/Files.expected: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/Files.ql: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/htmlSinks.expected: Language not supported
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/App.razor: Evaluated as low risk
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/MainLayout.razor: Evaluated as low risk
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/Layout/NavMenu.razor: Evaluated as low risk
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/MyInput.razor: Evaluated as low risk
  • csharp/ql/integration-tests/all-platforms/blazor/BlazorTest/Components/MyOutput.razor: Evaluated as low risk

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

public string? Value { get; set; } = "";
}

private const string XssUrl = "<b>aaaa<%2Fb>";
Copy link
Preview

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value of the XssUrl constant contains an invalid HTML tag (<%2Fb>). It should be corrected to <b>aaaa</b>.

Suggested change
private const string XssUrl = "<b>aaaa<%2Fb>";
private const string XssUrl = "<b>aaaa</b>";

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

@egregius313 egregius313 merged commit 6ac82d6 into github:main Jan 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants