Skip to content

JS: Migrate to shared data flow library (targeting main!) 🚀 #18467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 548 commits into from
Jan 16, 2025

Merge pull request #18451 from asgerf/jss/cleanup-todos

0f6e8bf
Select commit
Loading
Failed to load commit list.
Merged

JS: Migrate to shared data flow library (targeting main!) 🚀 #18467

Merge pull request #18451 from asgerf/jss/cleanup-todos
0f6e8bf
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
GitHub Advanced Security / CodeQL failed Jan 10, 2025 in 1m 6s

5 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 5 configurations present on refs/heads/main were not found:

Actions workflow (rust-analysis.yml)

  • ❓  .github/workflows/rust-analysis.yml:analyze/language:rust

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

Actions workflow (codeql-analysis.yml)

  • ❓  .github/workflows/codeql-analysis.yml:CodeQL-Build

Actions workflow (cpp-swift-analysis.yml)

  • ❓  .github/workflows/cpp-swift-analysis.yml:CodeQL-Build

New alerts in code changed by this pull request

  • 2 errors
  • 83 warnings
  • 69 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 1405 in javascript/ql/lib/semmle/javascript/dataflow/Configuration.qll

See this annotation in the file changed.

Code scanning / CodeQL

Candidate predicate not marked as `nomagic` Warning

Candidate predicate to
summarizedHigherOrderCall
Loading
is not marked as nomagic.

Check warning on line 51 in javascript/ql/lib/semmle/javascript/dataflow/FlowSummary.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'behaviour', which should instead be 'behavior'.
This comment contains the non-US spelling 'modelled', which should instead be 'modeled'.

Check warning on line 242 in javascript/ql/lib/semmle/javascript/dataflow/internal/BarrierGuards.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 344 in javascript/ql/lib/semmle/javascript/dataflow/internal/BarrierGuards.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check notice on line 387 in javascript/ql/lib/semmle/javascript/dataflow/internal/BarrierGuards.qll

See this annotation in the file changed.

Code scanning / CodeQL

Field only used in CharPred Note

Field is only used in CharPred.

Check warning on line 317 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style. Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 323 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style. Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 330 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 336 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 341 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 346 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 351 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 361 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 370 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 375 in javascript/ql/lib/semmle/javascript/dataflow/internal/Contents.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style Warning

The QLDoc for a predicate with a result should start with 'Gets'.

Check warning on line 118 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowNode.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 127 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 209 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 225 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 283 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 440 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Class QLDoc style Warning

The QLDoc for a class should start with 'A', 'An', or 'The'.

Check warning on line 676 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelled', which should instead be 'modeled'.

Check warning on line 813 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 1109 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Misspelling Warning

This comment contains the non-US spelling 'modelled', which should instead be 'modeled'.

Check warning on line 1203 in javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll

See this annotation in the file changed.

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
SsaInputNode
Loading
.