Skip to content

C#: Extract string interpolation alignment and format. #19089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelnebel merged 9 commits into from
Apr 1, 2025
Merged

C#: Extract string interpolation alignment and format. #19089

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
af6e1bd
C#: Extract alignment and format clauses of string interpolation expr…
michaelnebel Mar 20, 2025
2ca5ec0
C#: Add some string interpolation tests with alignment and formatting.
michaelnebel Mar 20, 2025
a73a61b
C#: Add PrintAst test for string interpolation expressions.
michaelnebel Mar 21, 2025
5ae7e5d
C#: Update other test expected output files.
michaelnebel Mar 21, 2025
acec97d
C#: Add change-note.
michaelnebel Mar 21, 2025
d9fb137
C#: Add upgrade- and downgrade scripts.
michaelnebel Mar 24, 2025
00753a1
C#: Address review comments.
michaelnebel Mar 28, 2025
e30fed6
C#: Improve upgrade script.
michaelnebel Mar 31, 2025
8e1282b
C#: Improve downgrade script.
michaelnebel Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions csharp/downgrades/66044cfa5bbf2ecfabd06ead25e91db2bdd79764/expressions.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
class Expression extends @expr {
string toString() { none() }
}

class TypeOrRef extends @type_or_ref {
string toString() { none() }
}

from Expression e, int k, int kind, TypeOrRef t
where
expressions(e, k, t) and
if k = 138 then kind = 106 else kind = k
select e, kind, t
Copy link
Contributor

@hvitved hvitved Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this select the insert part of e instead of e?

Copy link
Contributor Author

@michaelnebel michaelnebel Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered doing that as well, but it requires that we also make changes to the expr_parent relation as well (this is what I am vaguely hinting in the PR description).
Basically, I am worried that I break some DB invariant by changing the parent/child relationship as a part of the script.
Should we attempt to make the better downgrade script? It requires
(1) Removing the insert expressions from the expressions relation
(2) Adjust the expr_parent relation
(3) Consider if we need to do something with the new dangling align and format expressions.

Loading