Skip to content

Rust: Update rust/diagnostic/database-quality #21347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geoffw0 merged 3 commits into from
Feb 20, 2026
+4 −2
Merged

Rust: Update rust/diagnostic/database-quality #21347

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
97a02ed
Rust: Remove MacroCallTargetStats from rust/diagnostic/database-quality.
geoffw0 Feb 18, 2026
fd5c5b5
Rust: Change note.
geoffw0 Feb 18, 2026
b08e4e1
Merge branch 'main' into toolstatus
geoffw0 Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rust/ql/src/change-notes/2026-02-18-database-quality.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* The macro resolution metric has been removed from `rust/diagnostic/database-quality`. This metric was found to be an unreliable indicator of database quality in many cases, leading to false alarms on the tool status page.
2 changes: 0 additions & 2 deletions rust/ql/src/queries/telemetry/DatabaseQualityDiagnostics.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ import codeql.util.Unit
private predicate diagnostic(string msg, float value, float threshold) {
CallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50
or
MacroCallTargetStatsReport::percentageOfOk(msg, value) and threshold = 50
or
ExprTypeStatsReport::percentageOfOk(msg, value) and threshold = 20
}

Expand Down
Loading