Skip to content

Inline expectation tests should always have space before and after $ #21405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 19 commits into from
Mar 5, 2026

Add change notes

c82f756
Select commit
Loading
Failed to load commit list.
Merged

Inline expectation tests should always have space before and after $ #21405

Add change notes
c82f756
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Mar 5, 2026 in 2s

2 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 2 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

New alerts in code changed by this pull request

  • 2 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 224 in shared/util/codeql/util/test/InlineExpectationsTest.qll

See this annotation in the file changed.

Code scanning / CodeQL

Omittable 'exists' variable Warning test

This exists variable can be omitted by using a don't-care expression
in this argument
Loading
.

Check warning on line 383 in shared/util/codeql/util/test/InlineExpectationsTest.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning test

This predicate starts with 'get' but does not return a value.