Skip to content

C++: Add model validation for constructor summary models #21426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 5 commits into from
Mar 10, 2026
Merged

C++: Add model validation for constructor summary models #21426

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63e8061
Add model validation for constructor summary models
owen-mc Mar 7, 2026
097681e
Update cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
owen-mc Mar 7, 2026
512e271
Make new predicate private
owen-mc Mar 9, 2026
d8007a8
Java: Make corresponding predicate private
owen-mc Mar 9, 2026
e0e5319
C#: Make corresponding predicate private
owen-mc Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,12 +353,26 @@
)
}

string getIncorrectConstructorSummaryOutput() {

Check warning on line 356 in cpp/ql/lib/semmle/code/cpp/dataflow/ExternalFlow.qll

View workflow job for this annotation

GitHub Actions / qldoc 

Missing QLdoc for classless-predicate ExternalFlow::CsvValidation::getIncorrectConstructorSummaryOutput/0
Copy link
Contributor

@jketema jketema Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this predicate is not private?

Copy link
Contributor Author

@owen-mc owen-mc Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I should have done that. I've done it now, and taken the liberty of fixing it for Java and C# in this PR as well. (I had to merge main in first.)

exists(string namespace, string type, string name, string output |
type = name or
type = name + "<" + any(string s)
|
summaryModel(namespace, type, _, name, _, _, _, output, _, _, _) and
output.matches("ReturnValue%") and
result =
"Constructor model for " + namespace + "." + type +
" should use `Argument[this]` in the output, not `ReturnValue`."
)
}

/** Holds if some row in a CSV-based flow model appears to contain typos. */
query predicate invalidModelRow(string msg) {
msg =
[
getInvalidModelSignature(), getInvalidModelInput(), getInvalidModelOutput(),
getInvalidModelSubtype(), getInvalidModelColumnCount(), KindVal::getInvalidModelKind()
getInvalidModelSubtype(), getInvalidModelColumnCount(), KindVal::getInvalidModelKind(),
getIncorrectConstructorSummaryOutput()
]
}
}
Expand Down
Loading