Skip to content

Make .NET CopilotClient.DisposeAsync graceful #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveSandersonMS merged 2 commits into from
Jul 7, 2026
Merged

Make .NET CopilotClient.DisposeAsync graceful #1932

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f863cf5
Make .NET CopilotClient.DisposeAsync graceful
SteveSandersonMS Jul 7, 2026
b81d1a9
ci: retrigger
SteveSandersonMS Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dotnet/src/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2391,13 +2391,15 @@ public void Dispose()
/// </summary>
/// <returns>A <see cref="ValueTask"/> representing the asynchronous dispose operation.</returns>
/// <remarks>
/// This method calls <see cref="ForceStopAsync"/> to immediately release all resources.
/// This method calls <see cref="StopAsync"/> to gracefully shut down the runtime and
/// release all resources. Use <see cref="ForceStopAsync"/> for an immediate hard stop
/// that skips graceful runtime shutdown.
/// </remarks>
public async ValueTask DisposeAsync()
{
if (_disposed) return;
_disposed = true;
await ForceStopAsync();
await StopAsync();
}

private class RpcHandler(CopilotClient client)
Expand Down
14 changes: 14 additions & 0 deletions dotnet/test/Unit/ClientSessionLifetimeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,20 @@ public async Task StopAsync_Requests_Runtime_Shutdown_For_Owned_Process()
Assert.Equal(1, server.RuntimeShutdownCount);
}

[Fact]
public async Task DisposeAsync_Requests_Runtime_Shutdown_For_Owned_Process()
{
await using var server = await FakeCopilotServer.StartAsync();
var client = new CopilotClient(new CopilotClientOptions { Connection = RuntimeConnection.ForUri(server.Url) });
await client.StartAsync();
using var process = StartExitedProcess();
await ReplaceConnectionCliProcessAsync(client, process);

await client.DisposeAsync();

Assert.Equal(1, server.RuntimeShutdownCount);
}

[Fact]
public async Task StopAsync_Does_Not_Throw_When_Runtime_Shutdown_Fails()
{
Expand Down
Loading