Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion nodejs/src/session.ts
Original file line number Diff line number Diff line change
Expand Up @@ -750,6 +750,10 @@ export class CopilotSession {
const outcomePromise = new Promise<SessionOutcome>((resolve) => {
resolveOutcome = resolve;
});
let resolveShutdown: (error: Error) => void;
const shutdownPromise = new Promise<Error>((resolve) => {
resolveShutdown = resolve;
});

let lastAssistantMessage: AssistantMessageEvent | undefined;

Expand All @@ -764,12 +768,24 @@ export class CopilotSession {
const error = new Error(event.data.message);
error.stack = event.data.stack;
resolveOutcome({ kind: "error", error });
} else if (event.type === "session.shutdown") {
const reason = event.data.errorReason ? `: ${event.data.errorReason}` : "";
const error = new Error(
`Session ${this.sessionId} shut down before becoming idle${reason}`
);
resolveOutcome({ kind: "error", error });
resolveShutdown(error);
Comment thread
connor4312 marked this conversation as resolved.
Outdated
}
});

let timeoutId: ReturnType<typeof setTimeout> | undefined;
try {
await this.send(options);
await Promise.race([
this.send(options),
shutdownPromise.then((error) => {
throw error;
}),
]);

const timeoutPromise = new Promise<never>((_, reject) => {
timeoutId = setTimeout(
Expand Down
29 changes: 29 additions & 0 deletions nodejs/test/session-send-and-wait.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,23 @@ function errorEvent(message: string): SessionEvent {
} as SessionEvent;
}

function shutdownEvent(errorReason?: string): SessionEvent {
return {
type: "session.shutdown",
id: "00000000-0000-4000-8000-000000000002",
parentId: null,
timestamp: new Date().toISOString(),
data: {
codeChanges: { filesModified: [], linesAdded: 0, linesRemoved: 0 },
errorReason,
modelMetrics: {},
sessionStartTime: Date.now(),
shutdownType: errorReason ? "error" : "routine",
totalApiDurationMs: 0,
},
} as SessionEvent;
}

function controlledSession(): {
session: CopilotSession;
sendStarted: Promise<void>;
Expand Down Expand Up @@ -134,4 +151,16 @@ describe("sendAndWait", () => {
errorFirst.resolveSend();
await expect(errorFirstPending).rejects.toThrow("first error");
});

it("rejects when the session shuts down before becoming idle", async () => {
const { session, sendStarted } = controlledSession();
const pending = session.sendAndWait({ prompt: "hi" });
await sendStarted;

session._dispatchEvent(shutdownEvent("runtime session was lost"));

await expect(pending).rejects.toThrow(
"Session session-1 shut down before becoming idle: runtime session was lost"
);
});
});
Loading