Skip to content

Fix Java builds with scoped npm registries on macOS #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edburns merged 3 commits into from
Aug 14, 2026
+71 −18
Merged

Fix Java builds with scoped npm registries on macOS #2338

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63a8478
Fix Java builds with scoped npm registries on macOS
edburns Aug 14, 2026
d86a54a
Merge branch 'main' into edburns/java-macos-test-changes-from-linux-x…
edburns Aug 14, 2026
d453dce
Test: replace external blocking processes
edburns Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions java/sdk/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@
<workingDirectory>${copilot.sdk.root}/test/harness</workingDirectory>
<arguments>
<argument>ci</argument>
<argument>--omit-lockfile-registry-resolved=true</argument>
Comment thread
edburns marked this conversation as resolved.
<argument>--loglevel</argument>
<argument>${npm.loglevel}</argument>
</arguments>
Expand All @@ -225,6 +226,7 @@
<arguments>
<argument>ci</argument>
<argument>--ignore-scripts</argument>
<argument>--omit-lockfile-registry-resolved=true</argument>
<argument>--loglevel</argument>
<argument>${npm.loglevel}</argument>
</arguments>
Expand Down
5 changes: 2 additions & 3 deletions java/sdk/src/test/java/com/github/copilot/CliServerManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@

private static Process startBlockingProcess() throws IOException {
boolean isWindows = System.getProperty("os.name").toLowerCase().contains("windows");
return (isWindows
? new ProcessBuilder(System.getenv("COMSPEC"), "/c", "more")
: new ProcessBuilder("/usr/bin/cat")).start();
return (isWindows ? new ProcessBuilder(System.getenv("COMSPEC"), "/c", "more") : new ProcessBuilder("cat"))
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
.start();
}

@Test
Expand Down
5 changes: 2 additions & 3 deletions java/sdk/src/test/java/com/github/copilot/JsonRpcClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,8 @@

private static Process startBlockingProcess() throws IOException {
boolean isWindows = System.getProperty("os.name").toLowerCase().contains("windows");
return (isWindows
? new ProcessBuilder(System.getenv("COMSPEC"), "/c", "more")
: new ProcessBuilder("/usr/bin/cat")).start();
return (isWindows ? new ProcessBuilder(System.getenv("COMSPEC"), "/c", "more") : new ProcessBuilder("cat"))
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
.start();
}

@Test
Expand Down
Loading