[Test] Update Permission Denial Snapshots for the New Runtime Message - #2357
Open
MRayermannMSFT wants to merge 6 commits into
Open
[Test] Update Permission Denial Snapshots for the New Runtime Message#2357MRayermannMSFT wants to merge 6 commits into
MRayermannMSFT wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates permission replay snapshots to match the runtime’s revised denial message.
Changes:
- Adds the trailing full stop to three
UserNotAvailabletool results. - Preserves existing stable error assertions.
Show a summary per file
| File | Description |
|---|---|
test/snapshots/permissions/should_handle_permission_handler_errors_gracefully.yaml |
Updates handler-error denial text. |
test/snapshots/permissions/should_deny_tool_operations_when_handler_explicitly_denies.yaml |
Updates explicit-denial text. |
test/snapshots/permissions/should_deny_tool_operations_when_handler_explicitly_denies_after_resume.yaml |
Updates resumed-session denial text. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
| - role: tool | ||
| tool_call_id: toolcall_1 | ||
| content: Permission denied and could not request permission from user | ||
| content: Permission denied and could not request permission from user. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This change updates three permission snapshots so they carry the denial text the runtime now sends. The tool result for a
UserNotAvailabledecision gains a trailing full stop.Why
github/copilot-agent-runtime#16319 makes permission denials name what was refused. The C#
PermissionE2ETestsreplay against these snapshots, and the proxy matches a request only when every message is identical. The old text no longer matches, so three tests fail withNo cached response found for POST /v1/messages. The assertions themselves still hold, because theerrorfield keeps its stable label.Merge this before that pull request. Its "Copilot SDK C# tests" legs build its branch against this repository's
main, so they stay red until these snapshots land.