Fix C# plugin E2E tests for live local marketplaces - #2373
Conversation
Detect copied versus live local-marketplace behavior by editing the source plugin manifest and observing the listed version. Preserve exact install, update, and update-all assertions for each mode. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9369c7a5-b2f7-4459-8070-bd5a6b94d88d
There was a problem hiding this comment.
Pull request overview
Updates C# plugin RPC E2E tests to support both copied and live local-marketplace plugin behavior.
Changes:
- Moves fixture versioning into
plugin.json. - Adds strict assertions for install, update, and update-all semantics in both modes.
- Verifies post-mutation plugin listings.
Show a summary per file
| File | Description |
|---|---|
dotnet/test/E2E/RpcServerPluginsE2ETests.cs |
Adapts local-marketplace E2E fixtures and assertions for copied and live plugins. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
Cross-SDK Consistency Review ✅This PR modifies only No cross-SDK consistency issues identified. The changes are purely test fixture improvements to handle two plugin installation modes (copied vs. live local-marketplace). This doesn't introduce any new public API or behavioral change that would need to be mirrored in Node.js, Python, Go, Java, or Rust SDKs.
|
Summary
This restores compatibility with both the CLI version pinned by copilot-sdk and current
github/copilot-agent-runtimemain after live repo-local marketplace loading was introduced.Validation
dotnet format dotnet\test\GitHub.Copilot.SDK.Test.csproj --verify-no-changes --no-restore --include dotnet\test\E2E\RpcServerPluginsE2ETests.cs@github/copilot1.0.81-6 CLI: 7 passedcopilot-agent-runtimemain atfdac918608using its Windowstest-build-Windowsartifact: 7 passed