Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using-github-cli-in-workflows.md #33693

Closed
wants to merge 1 commit into from

Conversation

edudepetris
Copy link

Update secrets.GITHUB_TOKEN as secret names must not start with GITHUB_

Why:

Secret names must not start with GITHUB_.

Update secrets.GITHUB_TOKEN as secret names must not start with GITHUB_
Copy link

welcome bot commented Jun 25, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 25, 2024
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/using-github-cli-in-workflows.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 25, 2024
@nguyenalex836
Copy link
Contributor

@edudepetris Thanks so much for opening a PR! I'll get this triaged for review ✨

@jc-clark jc-clark added the needs SME This proposal needs review from a subject matter expert label Jun 25, 2024
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@nguyenalex836
Copy link
Contributor

@edudepetris Thank you for your patience while our engineering team reviewed your PR! ✨ After review, they shared the following -

secrets.GITHUB_TOKEN is automatically created for every workflow. It is true that you can't create your own secrets that start with GITHUB_ but in this case the system automatically creates this one

The example [in the doc] is showing how to use the built-in GITHUB_TOKEN to authenticate with the gh cli, it's not suggesting users define a secret named GITHUB_TOKEN.

For these reasons, we will go ahead and close this PR 💛 However, if you're looking for another issue to pick up , take a look at our help wanted section to find open issues you can work on ✨

Thank you for your willingness to contribute to GitHub Docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants