Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes GHES docs for PAT as SSO not available #33695

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fixes GHES docs for PAT as SSO not available #33695

wants to merge 9 commits into from

Conversation

amarvin
Copy link

@amarvin amarvin commented Jun 25, 2024 •
edited
Loading

Why:

GitHub Enterprise Server (GHES) allows generating personal access tokens (PATs), but unlike GitHub Cloud or GitHub Enterprise Cloud (GHEC) there is no option in GHES to enable SAML SSO for PATs.

Closes: #33696

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Adds a screenshot from GHES that doesn't show PAT with "configure SSO"
  • Updates PAT docs to use new screenshot for GHES

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@welcome Welcome
Copy link

welcome bot commented Jun 25, 2024

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Jun 25, 2024
@amarvin amarvin temporarily deployed to preview-env-33695 June 25, 2024 14:49 — with GitHub Actions Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens.md fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9
fpt
ghec
ghes@ 3.13 3.12 3.11 3.10 3.9

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@amarvin amarvin marked this pull request as ready for review June 25, 2024 14:53
@amarvin amarvin temporarily deployed to preview-env-33695 June 25, 2024 15:00 — with GitHub Actions Inactive
@amarvin amarvin temporarily deployed to preview-env-33695 June 25, 2024 15:23 — with GitHub Actions Inactive
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team authentication Content relating to authentication waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Jun 25, 2024
@nguyenalex836
Copy link
Contributor

@amarvin Thanks so much for opening a PR! I'll get this triaged for review ✨

@amarvin
Copy link
Author

amarvin commented Jun 25, 2024

Thanks, @nguyenalex836!

luddyinthehouse
luddyinthehouse reviewed Jun 29, 2024
View reviewed changes
.../authentication/keeping-your-account-and-data-secure/managing-your-personal-access-tokens.md
@@ -147,7 +147,7 @@ If you selected an organization as the resource owner and the organization requi
1. Click **Generate token**.
1. Optionally, to copy the new token to your clipboard, click {% octicon "copy" aria-label="Copy token" %}.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoped on a winner in winning..i'm out
in ’’’
lan zero epoxed left to decisions going late left podt.

luddyinthehouse
luddyinthehouse reviewed Jun 29, 2024
View reviewed changes
Copy link

@luddyinthehouse luddyinthehouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gathers interested visible intros to resting ideal number get on informational held with tough ways of not embellishments but distance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luddyinthehouse luddyinthehouse luddyinthehouse left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
authentication Content relating to authentication content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix GHES docs for PAT as SSO not available
3 participants
@amarvin @nguyenalex836 @luddyinthehouse