-
Notifications
You must be signed in to change notification settings - Fork 530
Relax approval gating for low-risk PR automations #53480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Copilot
wants to merge
8
commits into
main
from
copilot/copilot-opt-investigate-high-action-required-rate
Closed
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4e79656
Initial plan
Copilot d3d8dd9
Relax automation PR approval gating
Copilot b8700fc
Update central routing test expectation
Copilot 48a7f51
Merge branch 'main' into copilot/copilot-opt-investigate-high-action-…
pelikhan 8042bc1
Merge branch 'main' into copilot/copilot-opt-investigate-high-action-…
github-actions[bot] b9a7409
Recompile agentic_commands.yml to include squad routing after merge
Copilot 5584cff
Merge branch 'main' into copilot/copilot-opt-investigate-high-action-…
github-actions[bot] b6a2da5
Override dispatched event_type with normalized identifier; fetch fork…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,9 @@ async function appendRoutingSummary(existingCommands, selectedCommand) { | |
| } | ||
|
|
||
| function eventIdentifier() { | ||
| if (context.eventName === "pull_request_target") { | ||
| return "pull_request"; | ||
|
Comment on lines
+46
to
+47
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in b6a2da5: both dispatch paths now override |
||
| } | ||
| if (context.eventName !== "issue_comment") { | ||
| return context.eventName; | ||
| } | ||
|
|
@@ -53,6 +56,7 @@ function resolveBodyText() { | |
| const bodyByEvent = { | ||
| issues: context.payload?.issue?.body ?? "", | ||
| pull_request: context.payload?.pull_request?.body ?? "", | ||
| pull_request_target: context.payload?.pull_request?.body ?? "", | ||
| issue_comment: context.payload?.comment?.body ?? "", | ||
| pull_request_review_comment: context.payload?.comment?.body ?? "", | ||
| pull_request_review: context.payload?.review?.body ?? "", | ||
|
|
@@ -215,7 +219,8 @@ async function addImmediateReaction(reaction) { | |
| }); | ||
| return; | ||
| } | ||
| case "pull_request": { | ||
| case "pull_request": | ||
| case "pull_request_target": { | ||
| const prNumber = context.payload?.pull_request?.number; | ||
| if (!prNumber) { | ||
| core.warning("Skipping immediate reaction: pull request number was not found in payload."); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b6a2da5: added an explicit
git fetch origin "refs/pull/${PR_NUMBER}/head:refs/gh-aw/pr-${PR_NUMBER}/head"before the diff commands so the fork's head commit is present locally without checking it out.