[test-parallel] Add t.Parallel() to safe codemod tests in pkg/cli (batch 2)

[github-actions]

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Details

Potential security threats were detected in the agent output.

Review the workflow run logs for details.

test> Generated by PR Description Updater for #53584 · auto · 48.9 AIC · ⌖ 6.52 AIC · ⊞ 7.6K · ◷

[github-actions]

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel skipped because pre-fetch PR data was unavailable: unable to fetch test file diff

🧪 Test quality analysis by Test Quality Sentinel

[github-actions]

✅ Ponytail Reviewer completed successfully!

Diff is purely mechanical: adds t.Parallel() to existing test functions/subtests across 24 codemod test files, nothing else changes. No dead code, speculative abstractions, reinvented stdlib, or unneeded dependencies to flag. Lean already. Ship.

Generated by Ponytail Reviewer for #53584

[github-actions]

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

[github-actions]

❌ Design Decision Gate 🏗️ failed during design decision gate check.

Warning

Threat Detection Engine Failure — The analysis engine could not complete. This is a tooling failure, not a security finding.

What happened

The threat detection engine failed to produce results.

Review the workflow run logs for details.

🏗️ ADR gate enforced by Design Decision Gate 🏗️

[github-actions]

Great work on systematically parallelizing these test files! 🚀

This PR looks solid — you have:

• ✅ Reviewed all 24 test files carefully for safety (no t.Setenv, no shared globals, file I/O scoped to t.TempDir())
• ✅ Added t.Parallel() to both top-level tests and subtests across the batch
• ✅ Validated with go build, go test -race, and gofmt
• ✅ Tracked state for round-robin continuation in the next run
• ✅ Kept the changes focused and test-behavior-preserving

The PR is well-described with clear criteria and validation results. Since this is still in draft, a quick heads-up: once you are ready to move it out of draft, reviewers will likely appreciate a summary of the cumulative parallelization progress (total tests parallelized across batches) for context.

Otherwise, this is ready for review!

Generated by ✅ Contribution Check · auto · 47 AIC · ⌖ 8.51 AIC · ⊞ 9.2K · ◷

[github-actions]

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

[github-actions]

Comment Memory

reviewed_at: 2026-08-18T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable correctness or concurrency regressions found
  - parallelized tests appear isolated and tempdir-scoped
files_reviewed:
  - pkg/cli/codemod_allowed_repos_current_test.go
  - pkg/cli/codemod_assign_to_agent_test.go
  - pkg/cli/codemod_bash_allowlist_unsupported_engine_test.go
  - pkg/cli/codemod_bash_anonymous_test.go
  - pkg/cli/codemod_bash_single_quoted_args_test.go
  - pkg/cli/codemod_bots_test.go
  - pkg/cli/codemod_byok_copilot_test.go
  - pkg/cli/codemod_checkout_persist_credentials_false_test.go
  - pkg/cli/codemod_cli_proxy_mode_test.go
  - pkg/cli/codemod_copilot_requests_feature_test.go
  - pkg/cli/codemod_dependabot_permissions_test.go
  - pkg/cli/codemod_difc_proxy_test.go
  - pkg/cli/codemod_discussion_flag_test.go
  - pkg/cli/codemod_discussion_trigger_categories_test.go
  - pkg/cli/codemod_effective_tokens_to_ai_credits_test.go
  - pkg/cli/codemod_engine_driver_test.go
  - pkg/cli/codemod_engine_env_secrets_test.go
  - pkg/cli/codemod_engine_max_runs_test.go
  - pkg/cli/codemod_engine_max_turns_test.go
  - pkg/cli/codemod_engine_model_test.go
  - pkg/cli/codemod_engine_steps_test.go
  - pkg/cli/codemod_expires_integer_test.go
  - pkg/cli/codemod_factory_test.go
  - pkg/cli/codemod_github_app_client_id_test.go
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 7.91 AIC · ⌖ 7.91 AIC · ⊞ 7K · ◷
_{Comment /review to run again}

[github-actions]

No actionable blocking issues found in the changed lines.

### Review notes

I checked the added t.Parallel() calls across the touched codemod tests for shared mutable state, process-global mutation, and temp-file collisions. The exercised helpers appear to work on per-test local inputs, and the one file-I/O case is scoped to t.TempDir().

The attempted grumpy-coder pass could not run in this environment because the binary is unavailable, so I discarded that advisory path and completed the review manually.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 7.91 AIC · ⌖ 7.91 AIC · ⊞ 7K
_{Comment /review to run again}

[github-actions]

The changes look correct. t.Parallel() is consistently added to all top-level test functions and their subtests across both files. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 24.2 AIC · ⌖ 8.73 AIC · ⊞ 5.7K

[github-actions]

Skills-Based Review 🧠

Applied /tdd — changes are additions-only (t.Parallel() calls) with no behavioral modifications.

📋 Assessment

Positive Highlights

• ✅ All 182 additions are t.Parallel() calls only — no test logic or assertions changed
• ✅ Both top-level Test* functions and their t.Run(...) subtests are correctly parallelized
• ✅ PR description clearly documents the safety criteria checked (no t.Setenv, no global mutable state, t.TempDir() scoping for file I/O)
• ✅ No loop-variable rebinding needed (Go 1.22+ semantics correctly noted)
• ✅ go test -race validation passed

No Issues Found

All t.Parallel() calls have correct syntax. No shared mutable state, environment mutations, or unsafe patterns were introduced. This batch is safe to merge.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 20.4 AIC · ⌖ 9.82 AIC · ⊞ 7.8K
_{Comment /matt to run again}

[Copilot]

Pull request overview

Adds safe parallel execution to codemod unit tests in pkg/cli, reducing test-suite runtime without changing assertions or production behavior.

Changes:

• Added t.Parallel() to eligible top-level tests.
• Parallelized independent table-driven and named subtests.
• Preserved isolated temporary-file usage and local test state.

Show a summary per file

File	Description
pkg/cli/codemod_github_app_client_id_test.go	Parallelizes client-ID migration tests.
pkg/cli/codemod_factory_test.go	Parallelizes codemod factory tests.
pkg/cli/codemod_expires_integer_test.go	Parallelizes expiration conversion tests.
pkg/cli/codemod_engine_steps_test.go	Parallelizes engine steps migration tests.
pkg/cli/codemod_engine_model_test.go	Parallelizes engine model migration tests.
pkg/cli/codemod_engine_max_turns_test.go	Parallelizes max-turns migration tests.
pkg/cli/codemod_engine_max_runs_test.go	Parallelizes max-runs migration tests.
pkg/cli/codemod_engine_env_secrets_test.go	Parallelizes engine secret cleanup tests.
pkg/cli/codemod_engine_driver_test.go	Parallelizes engine driver migration tests.
pkg/cli/codemod_effective_tokens_to_ai_credits_test.go	Parallelizes AI-credit migration tests.
pkg/cli/codemod_discussion_trigger_categories_test.go	Parallelizes discussion category tests.
pkg/cli/codemod_discussion_flag_test.go	Parallelizes discussion flag tests.
pkg/cli/codemod_difc_proxy_test.go	Parallelizes DIFC proxy migration tests.
pkg/cli/codemod_dependabot_permissions_test.go	Parallelizes Dependabot permission tests.
pkg/cli/codemod_copilot_requests_feature_test.go	Parallelizes Copilot permission migration tests.
pkg/cli/codemod_cli_proxy_mode_test.go	Parallelizes CLI proxy migration tests.
pkg/cli/codemod_checkout_persist_credentials_false_test.go	Parallelizes checkout credential tests.
pkg/cli/codemod_byok_copilot_test.go	Parallelizes BYOK feature removal tests.
pkg/cli/codemod_bots_test.go	Parallelizes bot trigger migration tests.
pkg/cli/codemod_bash_single_quoted_args_test.go	Parallelizes Bash argument rewrite tests.
pkg/cli/codemod_bash_anonymous_test.go	Parallelizes anonymous Bash migration tests.
pkg/cli/codemod_bash_allowlist_unsupported_engine_test.go	Parallelizes isolated allowlist tests.
pkg/cli/codemod_assign_to_agent_test.go	Parallelizes agent assignment migration tests.
pkg/cli/codemod_allowed_repos_current_test.go	Parallelizes repository scope migration tests.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 24/24 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.1