[squad] Implement #53518: WHERE inference and generated prompt output - #53745
Merged
pelikhan merged 1 commit intoAug 18, 2026
Merged
Conversation
…d generated prompt view - Explain the inferred WHERE destination with reasoning based on goal/trigger - Track explicit destination overrides separately from inferred defaults - Add a task-description free-text step appended to the final prompt - Add a final generated-prompt step with a copy-to-clipboard action Closes #53518 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
August 18, 2026 16:31
pelikhan
deleted the
squad/implement-53518-where-inference-prompt-40fe2ba5ef6160ec
branch
August 18, 2026 16:31
Contributor
Author
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Extends the docs wizard with destination inference explanations, override tracking, task details, and a copyable generated prompt.
Changes:
- Adds destination inference and override handling.
- Adds task-description and final-prompt steps.
- Adds prompt copying and related styling.
Show a summary per file
| File | Description |
|---|---|
docs/src/components/Wizard.astro |
Implements the expanded five-step wizard experience. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (2)
docs/src/components/Wizard.astro:212
- A selected trigger does not necessarily supply the inference. For example, issue automation with manual dispatch has no destination matching
workflow_dispatch, so the code falls back to the goal default but claims that the trigger commonly pairs with it. Check whether the selected destination actually declares the trigger type before presenting that reason.
const reason = trigger
? `because the "${trigger.text.label}" trigger commonly pairs with this output`
: 'based on the selected goal';
docs/src/components/Wizard.astro:462
- The assembled final prompt can still omit the structured WHEN answer: most trigger options have no
text.help, so selections such as Every day or manual dispatch renderTrigger intent: —rather than the model'sfrontmatterintent. Derive a readable intent fromtrigger.frontmatter, or add model-authored summaries, before presenting this as the copy-ready prompt.
'WHERE',
`- Destination: ${destination?.text.label ?? '—'}`,
`- Output intent: ${destination?.text.help ?? destination?.safeOutputType ?? '—'}`,
- Files reviewed: 1/1 changed files
- Comments generated: 4
- Review effort level: Balanced
Comment on lines
110
to
112
| state.triggerId = value; | ||
| state.destinationOverridden = false; | ||
| syncDestinationSelection(); |
| label: 'Where', | ||
| title: 'Review the inferred output destination', | ||
| description: 'The shell preselects a destination from the model based on the selected goal and trigger type, while still allowing review.', | ||
| description: getDestinationStepDescription(), |
Comment on lines
+148
to
+150
| { | ||
| id: 'task-details', | ||
| label: 'Task', |
Comment on lines
+449
to
450
| const lines = [ | ||
| intro, |
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the docs-side AW wizard shell (
docs/src/components/Wizard.astro) with:state.destinationOverridden) from inferred defaults, so re-selecting a trigger or goal that invalidates the override resets it, but the wizard won't silently clobber a deliberate user choice.Inference rules remain fully data-driven from
wizard-data-model.json(inferFromTriggerTypeson each destination option), consistent with the existing model.Validation
cd docs && npm run buildcompletes successfully (225 pages built,/wizard/index.htmlincluded, no broken links).Closes #53518
Add this agentic workflow to your repo
To install this agentic workflow, run