Make no-json-stringify-set-or-map binding-aware to avoid cross-scope name collisions

[Copilot]

no-json-stringify-set-or-map previously tracked Set/Map candidates by bare identifier name at file scope, so same-named variables in different lexical scopes could be misclassified. This change resolves JSON.stringify(x) against x’s actual binding before deciding whether it was initialized as new Set(...) or new Map(...).

• Scope-aware binding resolution

  • Replaced flat Map<string, "Set" | "Map"> tracking with lexical lookup via ESLint scope (sourceCode.getScope(...) + variable defs).
  • For JSON.stringify(identifier), the rule now checks the specific resolved binding and flags only when that binding is a const initialized from global Set/Map construction.
  • Inline cases (JSON.stringify(new Set(...)) / new Map(...)) remain unchanged.

• Regression coverage for same-name variables across scopes

  • Added tests with two functions in one file that both declare seen, where one is new Set(...) and the other is a plain object.
  • Added both declaration orders to guard against traversal-order sensitivity.
  • Added a valid-case regression confirming the non-Set same-name binding is not flagged.

function withSet() {
  const seen = new Set([1, 2]);
  JSON.stringify(seen); // flagged
}

function withObject() {
  const seen = { other: true };
  JSON.stringify(seen); // not flagged
}

• Fixes eslint-factory: no-json-stringify-set-or-map tracks Set/Map variables by bare name, not by scope #54163

[Copilot]

Pull request overview

Makes the ESLint rule resolve Set/Map variables by lexical binding rather than identifier name.

Changes:

• Adds scope-aware resolution for const Set/Map bindings.
• Adds regression tests for cross-scope name collisions and declaration order.

Show a summary per file

File	Description
eslint-factory/src/rules/no-json-stringify-set-or-map.ts	Resolves the exact variable binding before reporting.
eslint-factory/src/rules/no-json-stringify-set-or-map.test.ts	Covers same-name bindings across scopes.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 2/2 changed files
• Comments generated: 0
• Review effort level: Balanced

[github-actions]

🎉 This pull request is included in a new release.

Release: v0.87.2