Skip to content

Prefer implicit engine defaults in workflow guidance - #57800

Merged
pelikhan merged 2 commits into
mainfrom
copilot/review-instructions-files
Sep 2, 2026
Merged

Prefer implicit engine defaults in workflow guidance#57800
pelikhan merged 2 commits into
mainfrom
copilot/review-instructions-files

Conversation

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Workflow authoring guidance inconsistently recommended specifying Copilot when no engine preference existed. Engine selection should remain implicit unless requirements demand otherwise, with Copilot preferred when a model constraint forces selection.

Changes

  • Authoring guidance

    • Omit engine: when no preference or engine-specific requirement exists.
    • Preserve explicit engine hints.
    • Try Copilot first when a model requirement requires selecting an engine.
  • Workflow generation

    • Remove redundant engine: copilot from the generic Craft example.
    • Align the Craft prompt with the same selection rules.
    • Regenerate the compiled Craft workflow.

Copilot AI and others added 2 commits September 2, 2026 00:11
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Clarify default agentic engine selection guidance Prefer implicit engine defaults in workflow guidance Sep 2, 2026
Copilot AI requested a review from pelikhan September 2, 2026 00:20
@pelikhan

pelikhan commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

@copilot merge main and recompile

Copilot AI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot merge main and recompile

Checked at 585f215: the latest origin/main is already contained in this branch. Recompiled all workflows with no generated drift, and make agent-report-progress passes.

@pelikhan
pelikhan marked this pull request as ready for review September 2, 2026 00:35
Copilot AI balanced review requested due to automatic review settings September 2, 2026 00:35
@pelikhan
pelikhan merged commit 73b4e35 into main Sep 2, 2026
1 check passed
@pelikhan
pelikhan deleted the copilot/review-instructions-files branch September 2, 2026 00:36

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Unrelated lockfiles alter production step ordering, and the new cross-file guidance contract lacks regression coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates workflow-authoring guidance to prefer implicit engine defaults while preserving explicit requirements.

Changes:

  • Aligns designer, creator, syntax, and Craft guidance.
  • Removes redundant engine: copilot from Craft’s example.
  • Regenerates Craft plus numerous unrelated workflow locks.
File summaries
File Description
.github/workflows/weekly-issue-summary.lock.yml Reorders generated imports.
.github/workflows/unbloat-docs.lock.yml Reorders generated imports.
.github/workflows/uk-ai-operational-resilience.lock.yml Reorders generated imports.
.github/workflows/ubuntu-image-analyzer.lock.yml Reorders generated imports.
.github/workflows/typist.lock.yml Reorders generated imports.
.github/workflows/terminal-stylist.lock.yml Reorders generated imports.
.github/workflows/stale-repo-identifier.lock.yml Reorders generated imports.
.github/workflows/spec-librarian.lock.yml Reorders generated imports.
.github/workflows/spec-extractor.lock.yml Reorders generated imports.
.github/workflows/smoke-pi.lock.yml Reorders generated imports.
.github/workflows/smoke-opencode.lock.yml Reorders generated imports.
.github/workflows/smoke-kiro.lock.yml Reorders generated imports.
.github/workflows/smoke-goose.lock.yml Reorders generated imports.
.github/workflows/smoke-gemini.lock.yml Reorders generated imports.
.github/workflows/smoke-deepseek-harness.lock.yml Reorders generated imports.
.github/workflows/smoke-cursor.lock.yml Reorders generated imports.
.github/workflows/smoke-crush.lock.yml Reorders generated imports.
.github/workflows/smoke-copilot.lock.yml Reorders generated imports.
.github/workflows/smoke-copilot-arm.lock.yml Reorders generated imports.
.github/workflows/smoke-copilot-aoai-entra.lock.yml Reorders imports and Azure authentication.
.github/workflows/smoke-copilot-aoai-apikey.lock.yml Reorders generated imports.
.github/workflows/smoke-codex.lock.yml Reorders generated imports.
.github/workflows/slide-deck-maintainer.lock.yml Reorders generated imports.
.github/workflows/skillet.lock.yml Reorders generated imports.
.github/workflows/sergo.lock.yml Reorders generated imports.
.github/workflows/semantic-function-refactor.lock.yml Reorders generated imports.
.github/workflows/security-review.lock.yml Reorders generated imports.
.github/workflows/schema-consistency-checker.lock.yml Reorders generated imports.
.github/workflows/safe-output-health.lock.yml Reorders generated imports.
.github/workflows/repository-quality-improver.lock.yml Reorders generated imports.
.github/workflows/repo-audit-analyzer.lock.yml Reorders generated imports.
.github/workflows/refiner.lock.yml Reorders generated imports.
.github/workflows/refactoring-cadence.lock.yml Reorders generated imports.
.github/workflows/python-data-charts.lock.yml Reorders generated imports.
.github/workflows/purelock.lock.yml Reorders generated imports.
.github/workflows/prompt-clustering-analysis.lock.yml Reorders imports and setup steps.
.github/workflows/pr-triage-agent.lock.yml Reorders generated imports.
.github/workflows/pr-nitpick-reviewer.lock.yml Reorders generated imports.
.github/workflows/pr-code-quality-reviewer.lock.yml Reorders generated imports.
.github/workflows/portfolio-analyst.lock.yml Reorders generated imports.
.github/workflows/ponytail-reviewer.lock.yml Reorders generated imports.
.github/workflows/mcp-inspector.lock.yml Reorders generated imports.
.github/workflows/mattpocock-skills-reviewer.lock.yml Reorders generated imports.
.github/workflows/lockfile-stats.lock.yml Reorders generated imports.
.github/workflows/linter-miner.lock.yml Reorders generated imports.
.github/workflows/impeccable-skills-reviewer.lock.yml Reorders generated imports.
.github/workflows/grumpy-reviewer.lock.yml Reorders generated imports.
.github/workflows/go-fan.lock.yml Reorders generated imports.
.github/workflows/glossary-maintainer.lock.yml Reorders generated imports.
.github/workflows/github-remote-mcp-auth-test.lock.yml Reorders generated imports.
.github/workflows/github-mcp-tools-report.lock.yml Reorders generated imports.
.github/workflows/github-mcp-structural-analysis.lock.yml Reorders generated imports.
.github/workflows/example-workflow-analyzer.lock.yml Reorders generated imports.
.github/workflows/eslint-refiner.lock.yml Reorders generated imports.
.github/workflows/duplicate-code-detector.lock.yml Reorders generated imports.
.github/workflows/docs-noob-tester.lock.yml Reorders generated imports.
.github/workflows/developer-docs-consolidator.lock.yml Reorders generated imports.
.github/workflows/detection-analysis-report.lock.yml Reorders imports and log retrieval.
.github/workflows/dependabot-burner.lock.yml Reorders generated imports.
.github/workflows/delight.lock.yml Reorders generated imports.
.github/workflows/dead-code-remover.lock.yml Reorders generated imports.
.github/workflows/daily-token-consumption-report.lock.yml Reorders generated imports.
.github/workflows/daily-testify-uber-super-expert.lock.yml Reorders generated imports.
.github/workflows/daily-team-evolution-insights.lock.yml Reorders generated imports.
.github/workflows/daily-spdd-spec-planner.lock.yml Reorders generated imports.
.github/workflows/daily-security-red-team.lock.yml Reorders generated imports.
.github/workflows/daily-security-observability.lock.yml Reorders Python setup and artifacts.
.github/workflows/daily-secrets-analysis.lock.yml Reorders generated imports.
.github/workflows/daily-safe-outputs-conformance.lock.yml Reorders generated imports.
.github/workflows/daily-safe-output-optimizer.lock.yml Reorders generated imports.
.github/workflows/daily-safe-output-integrator.lock.yml Reorders generated imports.
.github/workflows/daily-repo-chronicle.lock.yml Reorders generated imports.
.github/workflows/daily-rendering-scripts-verifier.lock.yml Reorders generated imports.
.github/workflows/daily-reliability-review.lock.yml Reorders generated imports.
.github/workflows/daily-regulatory.lock.yml Reorders generated imports.
.github/workflows/daily-performance-summary.lock.yml Reorders generated imports.
.github/workflows/daily-observability-report.lock.yml Reorders generated imports.
.github/workflows/daily-news.lock.yml Reorders generated imports.
.github/workflows/daily-multi-device-docs-tester.lock.yml Reorders generated imports.
.github/workflows/daily-mcp-concurrency-analysis.lock.yml Reorders generated imports.
.github/workflows/daily-malicious-code-scan.lock.yml Reorders generated imports.
.github/workflows/daily-issues-report.lock.yml Reorders imports and NLP setup.
.github/workflows/daily-graft-intelligence.lock.yml Reorders generated imports.
.github/workflows/daily-geo-optimizer.lock.yml Reorders generated imports.
.github/workflows/daily-function-namer.lock.yml Reorders generated imports.
.github/workflows/daily-formal-spec-verifier.lock.yml Reorders generated imports.
.github/workflows/daily-file-diet.lock.yml Reorders generated imports.
.github/workflows/daily-experiment-report.lock.yml Reorders generated imports.
.github/workflows/daily-doc-healer.lock.yml Reorders generated imports.
.github/workflows/daily-compiler-threat-spec-optimizer.lock.yml Reorders generated imports.
.github/workflows/daily-compiler-quality.lock.yml Reorders generated imports.
.github/workflows/daily-code-metrics.lock.yml Reorders generated imports.
.github/workflows/daily-cli-tools-tester.lock.yml Reorders generated imports.
.github/workflows/daily-cli-performance.lock.yml Reorders generated imports.
.github/workflows/daily-architecture-diagram.lock.yml Reorders generated imports.
.github/workflows/craft.md Applies implicit-engine generation guidance.
.github/workflows/craft.lock.yml Updates Craft’s generated body hash.
.github/workflows/copilot-session-insights.lock.yml Reorders generated imports.
.github/workflows/copilot-pr-prompt-analysis.lock.yml Reorders generated imports.
.github/workflows/copilot-pr-nlp-analysis.lock.yml Reorders imports and data fetching.
.github/workflows/copilot-pr-merged-report.lock.yml Reorders generated imports.
.github/workflows/copilot-agent-analysis.lock.yml Reorders generated imports.
.github/workflows/code-simplifier.lock.yml Reorders generated imports.
.github/workflows/code-scanning-fixer.lock.yml Reorders generated imports.
.github/workflows/cloclo.lock.yml Reorders generated imports.
.github/workflows/claude-code-user-docs-review.lock.yml Reorders generated imports.
.github/workflows/ci-coach.lock.yml Reorders generated imports.
.github/workflows/breaking-change-checker.lock.yml Reorders generated imports.
.github/workflows/blog-auditor.lock.yml Reorders generated imports.
.github/workflows/audit-workflows.lock.yml Reorders generated imports.
.github/workflows/architecture-guardian.lock.yml Reorders generated imports.
.github/workflows/archie.lock.yml Reorders generated imports.
.github/workflows/api-consumption-report.lock.yml Reorders generated imports.
.github/workflows/agent-job-health.lock.yml Reorders generated imports.
.github/aw/syntax-engine.md Documents implicit engine defaults.
.github/aw/designer.md Revises engine interview guidance.
.github/aw/create-agentic-workflow.md Aligns workflow-creation guidance.
Review details
  • Files reviewed: 117/117 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread .github/aw/designer.md
Comment on lines +107 to +110
If there is no engine preference or engine-specific requirement, do not suggest
or specify an engine; omit `engine:` and let the configured default apply. If an
explicit model requirement forces engine selection, try Copilot first and select
another engine only when Copilot cannot satisfy that requirement.
Comment on lines +820 to +824
- env:
GH_AW_AZURE_CLIENT_ID: adb907fd-188c-4029-b67f-2559d96b2f1b
GH_AW_AZURE_TENANT_ID: 398a6654-997b-47e9-b12b-9515b896b4de
name: Re-authenticate Azure CLI with OIDC
run: "if [ -z \"$GH_AW_AZURE_OIDC_TOKEN_FILE\" ] || [ ! -f \"$GH_AW_AZURE_OIDC_TOKEN_FILE\" ]; then\n echo \"::error::Azure OIDC token file not found — the Fetch Azure OIDC token step may have failed\"\n exit 1\nfi\nmkdir -p \"$AZURE_CONFIG_DIR\"\nchmod 700 \"$AZURE_CONFIG_DIR\"\ncleanup() {\n rm -f \"$GH_AW_AZURE_OIDC_TOKEN_FILE\"\n}\ntrap cleanup EXIT\naz login --service-principal \\\n --username \"$GH_AW_AZURE_CLIENT_ID\" \\\n --tenant \"$GH_AW_AZURE_TENANT_ID\" \\\n --federated-token \"$(cat \"$GH_AW_AZURE_OIDC_TOKEN_FILE\")\" \\\n --output none \\\n --only-show-errors\naz account show --output table\n"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants