Import concurrency job discriminator from shared workflows by Copilot · Pull Request #57978 · github/gh-aw

Copilot · 2026-09-02T15:33:18Z

Shared workflows can now provide concurrency.job-discriminator. The main workflow takes precedence when both define one.

Changes

Import semantics
- First imported discriminator wins across shared workflows.
- Main workflow discriminator overrides imported values.
Validation
- Allows only job-discriminator under shared workflow concurrency.
- Continues rejecting workflow-level concurrency settings such as group.

# shared.md
concurrency:
  job-discriminator: ${{ inputs.item_id }}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-09-02T16:12:38Z

@copilot allow the entire group field to be merged from shared agentic workflows as a whole

Copilot

🟡 Changes recommended

Unsupported concurrency fields are not rejected through common shared-subdirectory import paths.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Imports shared concurrency.job-discriminator values while preserving main-workflow precedence.

Changes:

Adds first-import-wins extraction and merge behavior.
Adds shared-workflow validation and tests.
Documents import precedence.

File summaries

File	Description
`pkg/workflow/concurrency_import_test.go`	Tests import and override behavior.
`pkg/workflow/compiler_orchestrator_workflow.go`	Applies the imported discriminator.
`pkg/parser/schema_validation.go`	Allows only the import-safe concurrency field.
`pkg/parser/schema_location_test.go`	Tests shared-workflow validation.
`pkg/parser/import_processor.go`	Exposes the merged discriminator.
`pkg/parser/import_field_extractor.go`	Extracts the first imported value.
`pkg/parser/import_field_extractor_test.go`	Tests first-wins extraction.
`pkg/constants/constants.go`	Removes concurrency from the blanket forbidden list.
`docs/src/content/docs/reference/concurrency.md`	Documents shared-workflow precedence.

Review details

Files reviewed: 9/9 changed files
Comments generated: 2
Review effort level: Balanced

+		if key == "concurrency" {
+			if err := validateSharedWorkflowConcurrencyField(frontmatter["concurrency"]); err != nil {
+				return err
+			}
+			continue


@@ -487,7 +487,6 @@ var IgnoredFrontmatterFields = []string{}
 // and will be properly imported and merged when the shared workflow is imported.
 var SharedWorkflowForbiddenFields = []string{


Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-02T16:41:43Z

@copilot allow the entire group field to be merged from shared agentic workflows as a whole

Updated: shared workflow concurrency.group is now carried through import processing and merged with main-workflow precedence intact; unsupported concurrency keys remain rejected.

pelikhan · 2026-09-02T17:17:26Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33656491885/job/100348121909?pr=57978

Copilot · 2026-09-02T17:22:46Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33656491885/job/100348121909?pr=57978

Fixed at 811a3d4: the shared-workflow concurrency import fix is in place, the Go formatting issue was corrected, and the focused parser/workflow concurrency regression checks pass.

gh-aw-bot · 2026-09-02T17:27:22Z

@copilot Please inspect the current failed checks on this PR, address any remaining issues, refresh the branch if needed, and run the pr-finisher skill before handing back to maintainers.

Current failed checks from compact context:
- impacted-go-tests
- lint-go-format
- lint-go-golangci
- Unit tests (A-C)
- Unit tests (H-M)
- Unit tests (S-Z and other)
Your latest reply says the formatting fix landed on the current head; please verify what still remains failing for maintainers.

Generated by 👨🍳 PR Sous Chef
_{Comment /souschef to run again}

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 29.3 AIC · ⌖ 8.78 AIC · ⊞ 8.7K · ◷
_{Comment /souschef to run again}

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

pelikhan · 2026-09-02T19:12:18Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33662782973/job/100367188334?pr=57978

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-09-02T19:29:13Z

 	mergedMaxAICredits       string
 	mergedMaxDailyAICredits  string
+	mergedConcurrency        string
+	mergedJobDiscriminator   string


@copilot this is a subset of discriminator so it is part of concurrency.

Copilot · 2026-09-02T19:34:42Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33662782973/job/100367188334?pr=57978

Fixed in 506f725: the nested shared-import regression was caused by the fixtures using the legacy mcp-servers.<name>.image shape, which trips schema validation. I updated the regression cases to use the valid container form and verified go test ./pkg/parser -count=1 passes.

gh-aw-bot · 2026-09-02T19:50:46Z

@copilot Please address the remaining unresolved review feedback on this PR, refresh the branch if needed, and run the pr-finisher skill before handing back to maintainers.

Unresolved review threads:
- pelikhan — Import concurrency job discriminator from shared workflows #57978 (comment)
- copilot-pull-request-reviewer — Import concurrency job discriminator from shared workflows #57978 (comment)
- copilot-pull-request-reviewer — Import concurrency job discriminator from shared workflows #57978 (comment)
Please reconcile the shared-workflow concurrency import behavior with the maintainer feedback and summarize the final rule clearly for reviewers.
After updating, run the pr-finisher skill before handing back.

Generated by 👨🍳 PR Sous Chef
_{Comment /souschef to run again}

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

github.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "github.com"

See Network Configuration for more information.

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 40.1 AIC · ⌖ 8.81 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

github-actions · 2026-09-03T05:09:53Z

🎉 This pull request is included in a new release.

Release: v0.88.2

Copilot AI and others added 3 commits September 2, 2026 15:24

Import shared concurrency job discriminator

a82666b

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Reduce discriminator import diff

b747695

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Clarify shared concurrency validation

35e2138

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Sep 2, 2026

Copilot created this pull request from a session on behalf of pelikhan September 2, 2026 15:34 View session

Copilot finished work on behalf of pelikhan September 2, 2026 15:34

Copilot AI requested a review from pelikhan September 2, 2026 15:34

pelikhan marked this pull request as ready for review September 2, 2026 16:12

Copilot AI balanced review requested due to automatic review settings September 2, 2026 16:12

Copilot started reviewing on behalf of pelikhan September 2, 2026 16:12 View session

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Copilot started work on behalf of pelikhan September 2, 2026 16:20 View session

Copilot AI and others added 2 commits September 2, 2026 16:39

Fix imported concurrency.group merge regression

b69b9a3

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Restore imported shared concurrency.group merge

811a3d4

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 2, 2026 16:42

This was referenced Sep 2, 2026

[pr-sous-chef] PR Sous Chef run report #57799

Closed

[Contribution Check Report] Contribution Check — 2026-09-02 #57811

Closed

Copilot started work on behalf of pelikhan September 2, 2026 17:17 View session

Copilot finished work on behalf of pelikhan September 2, 2026 17:23

Copilot started work on behalf of gh-aw-bot September 2, 2026 17:27 View session

Apply remaining changes

9c7440f

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot September 2, 2026 17:43

Copilot AI requested a review from gh-aw-bot September 2, 2026 17:43

Merge branch 'main' into copilot/ensure-group-discriminator-import

894e980

Copilot started work on behalf of pelikhan September 2, 2026 19:12 View session

pelikhan and others added 2 commits September 2, 2026 12:15

Merge branch 'main' into copilot/ensure-group-discriminator-import

9ca75c1

Fix nested import test fixtures to use valid MCP schema

506f725

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 2, 2026 19:22

pelikhan reviewed Sep 2, 2026

View reviewed changes

Copilot started work on behalf of pelikhan September 2, 2026 19:29 View session

Copilot finished work on behalf of pelikhan September 2, 2026 19:35

Copilot AI requested a review from pelikhan September 2, 2026 19:35

Copilot started work on behalf of gh-aw-bot September 2, 2026 19:51 View session

Copilot finished work on behalf of gh-aw-bot September 2, 2026 20:04

pelikhan merged commit 939e997 into main Sep 2, 2026
36 checks passed

pelikhan deleted the copilot/ensure-group-discriminator-import branch September 2, 2026 20:39

github-actions Bot mentioned this pull request Sep 3, 2026

Smoke Test: MAI-Code-1-Flash - 33697845057 #58062

Closed

github-actions Bot mentioned this pull request Sep 3, 2026

Suggested test: copilot/concurrency-job-discriminator-import githubnext/gh-aw-test#13853

Open

Navigation Menu

Uh oh!

Import concurrency job discriminator from shared workflows - #57978

Import concurrency job discriminator from shared workflows#57978
pelikhan merged 9 commits into
mainfrom
copilot/ensure-group-discriminator-import

Copilot AI commented Sep 2, 2026 •

edited

Loading

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

gh-aw-bot commented Sep 2, 2026

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

pelikhan Sep 2, 2026

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

gh-aw-bot commented Sep 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -487,7 +487,6 @@ var IgnoredFrontmatterFields = []string{}
		// and will be properly imported and merged when the shared workflow is imported.
		var SharedWorkflowForbiddenFields = []string{

Uh oh!

Conversation

Copilot AI commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

gh-aw-bot commented Sep 2, 2026

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

pelikhan Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

gh-aw-bot commented Sep 2, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 2, 2026 •

edited

Loading