feat(manifest): add optional icon field supporting emoji, octicon, and SVG resources by Copilot · Pull Request #58047 · github/gh-aw

Copilot · 2026-09-02T22:56:47Z

Adds support for an optional icon field in aw.yml package manifests. Icons accept a Unicode emoji, a GitHub Primer Octicon name using :name: syntax, or a path to an SVG file declared in the package resources list.

Manifest Example

manifest-version: "1"
name: "my-package"
icon: ":check-circle:" # or "📦" or "assets/logo.svg"
resources:
  - src: "assets/logo.svg"

Schema & Data Models

JSON Schema (pkg/parser/schemas/aw_manifest_schema.json): Added optional icon string property.
Structs (pkg/cli/): Added Icon string field to repositoryPackageManifest and resolvedRepositoryPackage.

Validation & Resolution

Icon Parsing (pkg/cli/add_package_manifest_parse.go): Added validateRepositoryPackageManifestIcon to validate the three permitted icon types:
- Unicode emoji character sequences.
- Primer Octicon identifiers matching :a-z0-9-: syntax.
- Case-insensitive .svg file paths matching a declared package resource src or dst.
Package Resolution (pkg/cli/add_package_manifest_resolve.go): Propagated Icon to resolved repository package output.

Specifications & Reference

Documentation (docs/src/content/docs/): Updated reference tables and specification details in aw-yml-package-manifest.md and repository-package-manifest-specification.md.

✨ PR Review Safe Output Test - Run 33698951158

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

clients2.google.com
mtalk.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "clients2.google.com"
    - "mtalk.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · claude · sonnet46 · 70.1 AIC · ⌖ 18.7 AIC · ⊞ 7.8K · ◷
_{Comment /smoke-claude to run again}

… and documentation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

🟡 Changes recommended

Invalid emoji values pass validation, local icons are dropped, generated content is inconsistent, and two executable workflows are deleted.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds optional package-manifest icons with emoji, Octicon, and SVG resource support.

Changes:

Extends manifest schema, models, validation, and resolution.
Adds tests and documentation.
Updates generated assets, including unintended workflow deletions.

File summaries

File	Description
`pkg/parser/schemas/aw_manifest_schema.json`	Adds the `icon` property.
`pkg/cli/data/agentic_workflows_fallback_aw_files.json`	Adds `compat.md` fallback.
`pkg/cli/add_package_manifest.go`	Adds resolved icon metadata.
`pkg/cli/add_package_manifest_test.go`	Tests icon parsing and validation.
`pkg/cli/add_package_manifest_resolve.go`	Propagates remote package icons.
`pkg/cli/add_package_manifest_parse.go`	Parses and validates icons.
`docs/src/content/docs/specs/repository-package-manifest-specification.md`	Specifies icon formats.
`docs/src/content/docs/reference/aw-yml-package-manifest.md`	Documents the icon field.
`.github/workflows/firewall.lock.yml`	Deletes the compiled firewall workflow.
`.github/workflows/example-permissions-warning.lock.yml`	Deletes the compiled example workflow.
`.github/skills/agentic-workflows/SKILL.md`	Removes the `compat.md` entry.

Review details

Suppressed comments (2)

.github/workflows/firewall.lock.yml:1

This removes the compiled GitHub Actions workflow while the unchanged .github/workflows/firewall.md source remains. The .lock.yml file is the executable workflow, so deleting it disables the Firewall Test Agent and is unrelated to the manifest-icon feature. Restore or regenerate this lock file before merging.
.github/workflows/example-permissions-warning.lock.yml:1
This removes the compiled GitHub Actions workflow while the unchanged .github/workflows/example-permissions-warning.md source remains. The .lock.yml file is the executable workflow, so deleting it disables the example workflow (and breaks its status link) despite this PR being scoped to manifest icons. Restore or regenerate this lock file before merging.

Files reviewed: 6/307 changed files
Comments generated: 4
Review effort level: Balanced

@@ -52,6 +52,7 @@ type resolvedRepositoryPackage struct {
 	ResolvedRef        string
 	Name               string
 	Emoji              string
+	Icon               string


+		if !isStr {
+			return fmt.Errorf("invalid Agentic Workflow manifest %q: icon must be a string", manifestPath)
+		}
+		manifest.Icon = icon


+		if unicode.Is(unicode.So, r) || (r >= 0x1F300 && r <= 0x1F9FF) || (r >= 0x2600 && r <= 0x27BF) || (r >= 0x1F1E6 && r <= 0x1F1FF) || r == 0x200D || r == 0xFE0F || (r >= 0x1F3FB && r <= 0x1F3FF) || r == 0x20E3 {
+			hasSymbol = true
+		} else if !unicode.Is(unicode.M, r) && r != '#' && r != '*' && (r < '0' || r > '9') {


pelikhan · 2026-09-02T23:31:21Z

@copilot merge main and recompile

gh-aw-bot · 2026-09-02T23:35:19Z

@copilot Please address the current blocking feedback on this manifest icon PR before handing back to maintainers.

The branch is currently conflicting/dirty; please run make merge-main first to resolve it cleanly and then make recompile if workflow outputs changed.
The current review says invalid emoji values still pass validation; tighten validation and add/update tests so unsupported emoji/icon formats are rejected clearly.
Local icons are reportedly dropped during resolution/generated output; preserve them end-to-end and cover that path with regression tests.
Restore/regenerate the deleted executable workflow lock files (.github/workflows/firewall.lock.yml and .github/workflows/example-permissions-warning.lock.yml) unless their source workflows changed intentionally.
The generated content / fallback AW file changes should match the repo state exactly; remove unrelated drift and keep the PR scoped to manifest icon support.
After the fix, run the pr-finisher skill and leave a concise maintainer-facing summary of what changed and which checks to re-run.

Generated by PR Sous Chef

Generated by 👨‍🍳 PR Sous Chef · pi · gpt54 · 45.8 AIC · ⌖ 8.69 AIC · ⊞ 9.2K · ◷
_{Comment /souschef to run again}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-09-02T23:47:39Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33696373964/job/100466381530?pr=58047

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-09-02T23:55:45Z

@copilot Please address the current blocking feedback on this manifest icon PR before handing back to maintainers.

The branch is currently conflicting/dirty; please run make merge-main first to r...

Implemented and pushed in the latest commit: merged current main, regenerated workflow outputs, restored executable lock files, preserved local icons, canonicalized icon values, and tightened emoji validation with regression tests. Focused CLI tests pass; the custom linter still reports pre-existing function-length/path-concatenation findings in add_workflow_resolution.go. CI needs a maintainer re-trigger.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot · 2026-09-03T00:04:02Z

@copilot fix https://github.com/github/gh-aw/actions/runs/33696373964/job/100466381530?pr=58047

Investigated run 33696373964, job 100466381530. The failure was TestCheckedInAgenticWorkflowsSkillMatchesGeneratedContent on the previous head; the synchronized skill content now passes. Also corrected the direct github.com/rivo/uniseg dependency metadata in commit 5fee0ec. Impacted tests pass; please re-trigger CI.

github-actions

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

clients2.google.com
mtalk.google.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "clients2.google.com"
    - "mtalk.google.com"

See Network Configuration for more information.

💥 [THE END] — Illustrated by Smoke Claude · claude · sonnet46 · 70.1 AIC · ⌖ 18.7 AIC · ⊞ 7.8K
_{Comment /smoke-claude to run again}

github-actions · 2026-09-03T00:31:12Z

 | `min-version` | string | No | Minimum compatible `gh aw` version in `vMAJOR.minor.patch` form, such as `v0.38.0`. |
 | `name` | string | Yes | Human-readable package name. Must be non-empty after trimming whitespace. |
 | `emoji` | string | No | Optional package emoji for display in package metadata. |
+| `icon` | string | No | Optional package icon: an emoji, a GitHub primer octicon name in `:name:` format (e.g. `:check-circle:`), or a package resource path to an SVG file. |


✅ Good addition! Consider adding an example value to make the icon format clearer for end users. Something like: emoji: "🚀" or octicon: ":rocket:" or svg: "assets/icon.svg".

github-actions · 2026-09-03T00:31:13Z

 | `min-version` | string | No | Minimum supported `gh-aw` version. |
 | `name` | string | Yes | Human-readable package name. |
 | `emoji` | string | No | Optional package emoji for display in package metadata. |
+| `icon` | string | No | Optional package icon: an emoji, a GitHub primer octicon name (`:...:`), or an SVG resource path. |


📝 The icon field specification looks good! It would be helpful to mention validation rules — for example, does the SVG path need to be relative to the package root? Clarifying constraints in the spec would prevent implementation ambiguity.

github-actions · 2026-09-03T05:09:31Z

🎉 This pull request is included in a new release.

Release: v0.88.2

Add icon field to aw.yml manifest schema, parsing, validation, tests,…

1b15fb9

… and documentation Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Sep 2, 2026

Apply remaining changes

a6a3cc7

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI changed the title ~~feat(manifest): add optional icon field supporting emoji, octicon, or SVG resource~~ feat(manifest): add optional icon field supporting emoji, octicon, and SVG resources Sep 2, 2026

Copilot finished work on behalf of pelikhan September 2, 2026 22:57

Copilot created this pull request from a session on behalf of pelikhan September 2, 2026 22:57 View session

Copilot AI requested a review from pelikhan September 2, 2026 22:57

pelikhan marked this pull request as ready for review September 2, 2026 22:59

Copilot AI balanced review requested due to automatic review settings September 2, 2026 22:59

Copilot started reviewing on behalf of pelikhan September 2, 2026 22:59 View session

Merge branch 'main' into copilot/add-icon-field-to-aw-manifest

ff79eaf

Copilot AI reviewed Sep 2, 2026

View reviewed changes

Merge branch 'main' into copilot/add-icon-field-to-aw-manifest

f48bf0e

Copilot started work on behalf of pelikhan September 2, 2026 23:31 View session

github-actions Bot mentioned this pull request Sep 2, 2026

[pr-sous-chef] PR Sous Chef run report #57799

Closed

Copilot AI and others added 2 commits September 2, 2026 23:36

Merge main into copilot/add-icon-field-to-aw-manifest

ac9d766

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Regenerate workflow lock after base merge

de3e412

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 2, 2026 23:43

Copilot started work on behalf of gh-aw-bot September 2, 2026 23:44 View session

Merge branch 'main' into copilot/add-icon-field-to-aw-manifest

56b8ef0

Fix manifest icon validation and local resolution

c8c36e0

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot September 2, 2026 23:56

Copilot AI requested a review from gh-aw-bot September 2, 2026 23:56

Copilot started work on behalf of pelikhan September 2, 2026 23:56 View session

github-actions Bot mentioned this pull request Sep 3, 2026

[pr-sous-chef] PR Sous Chef run report #58057

Closed

Mark emoji dependency as direct import

5fee0ec

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot finished work on behalf of pelikhan September 3, 2026 00:04

github-actions Bot mentioned this pull request Sep 3, 2026

Smoke Test: Claude - 33698951158 #58075

Closed

github-actions Bot reviewed Sep 3, 2026

View reviewed changes

pelikhan merged commit b4fadaa into main Sep 3, 2026
36 checks passed

pelikhan deleted the copilot/add-icon-field-to-aw-manifest branch September 3, 2026 01:38

Navigation Menu

Uh oh!

feat(manifest): add optional icon field supporting emoji, octicon, and SVG resources - #58047

feat(manifest): add optional icon field supporting emoji, octicon, and SVG resources#58047
pelikhan merged 9 commits into
mainfrom
copilot/add-icon-field-to-aw-manifest

Copilot AI commented Sep 2, 2026 •

edited by github-actions Bot

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

gh-aw-bot commented Sep 2, 2026

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

Copilot AI commented Sep 3, 2026

Uh oh!

github-actions Bot left a comment

Uh oh!

github-actions Bot Sep 3, 2026

Uh oh!

github-actions Bot Sep 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Copilot AI commented Sep 2, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Manifest Example

Schema & Data Models

Validation & Resolution

Specifications & Reference

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (2)

Uh oh!

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

gh-aw-bot commented Sep 2, 2026

Uh oh!

pelikhan commented Sep 2, 2026

Uh oh!

Copilot AI commented Sep 2, 2026

Uh oh!

Copilot AI commented Sep 3, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Sep 2, 2026 •

edited by github-actions Bot

Loading