Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more reference selection options #81

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Conversation

mhagger
Copy link
Member

@mhagger mhagger commented Jul 8, 2021

Add some more reference selection options. The same functionality could be achieved using the existing options, but it's more convenient to have these dedicated options as shorthand:

  • --no-branches, --no-tags, --no-remotes — the opposite of the existing branches, --tags, and --remotes options.
  • --notes and --no-notes — include or exclude refs/notes/*.
  • --stash and --no-stash — include or exclude refs/stash.

Add tests to cover the new options, driven by a grid of expected results.

/cc @chrisd8088 or @larsxschneider as possible reviewers.

@mhagger
Copy link
Member Author

mhagger commented Jul 8, 2021

I forgot to mention: this fixes #77.

Add some more reference selection options. The same functionality
could be achieved using the existing options, but it's more convenient
to have these dedicated options as shorthand:

* `--no-branches`, `--no-tags`, `--no-remotes` — the opposite of the
  existing `branches`, `--tags`, and `--remotes` options.

* `--notes` and `--no-notes` — include or exclude `refs/notes/*`.

* `--stash` and `--no-stash` — include or exclude `refs/stash`.
@mhagger
Copy link
Member Author

mhagger commented Sep 18, 2021

I just rebased this branch to master, without any code changes. There was a minor textual conflict in the usage string.

/cc @ttaylorr as a possible reviewer.

Copy link
Member

@ttaylorr ttaylorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks plausibly correct to me. 👍

@mhagger mhagger merged commit 9a4dc3b into master Sep 20, 2021
@mhagger mhagger deleted the more-ref-options branch September 20, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants