Fix nil pointer dereference in completion handler #1754
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a nil pointer dereference panic in
RepositoryResourceCompletionHandlerwhen theContextfield is not provided in the completion request.Problem
The
CompleteParams.Contextfield in the MCP protocol is optional (marked asomitemptyand is a pointer type*CompleteContext). When clients don't include it in their requests, the code was panicking because it directly accessedreq.Params.Context.Argumentswithout first checking ifContextwas nil.Solution
Added a nil check for
Contextbefore accessingArguments:Testing
TestRepositoryResourceCompletionHandler_NilContextspecifically covers this scenario