-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: made envs application actually NOP #691
Conversation
@decyjphr Another contribution from my company, We noticed this is an issue which people does not noticed and it impact environments. |
Any objection to this one @decyjphr ? I would love to see it merged. |
It looks like plugins have received an update to include an errors parameter so this plugin may not be 100% in line, if that's a problem I can update it sometime in the next week or so. |
Merge conflicts resolved. Ready to merge if possible. |
Thanks @randomcascade will look into merging this soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Is this working for you @randomcascade ? We are still seeing environment changes being applied to production for unmerged PRs. We also don't see proposed environment changes in the dry-run comments. |
Fixes: #551 Would love if someone else could validate the testing as I'm not sure I've tested every case.