Fix up paths for KV to align with new values#6
Merged
jasonrclark merged 1 commit intomainfrom May 5, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the KV service endpoints to use the new /_spark prefix for both frontend environment variables and local development proxies.
- Changed
BASE_KV_SERVICE_URLfrom"/kv"to"/_spark/kv" - Updated dev server proxy paths for KV and LLM to include
/_sparkprefix
Comments suppressed due to low confidence (2)
vite.config.ts:44
- Consider adding a corresponding
BASE_LLM_SERVICE_URLdefinition for"/_spark/llm"so the LLM service URL is available via environment variables, mirroring the KV change.
BASE_KV_SERVICE_URL: JSON.stringify("/_spark/kv"),
vite.config.ts:74
- Add a
rewriterule to strip the/_sparkprefix when proxying to the backend (e.g.,rewrite: path => path.replace(/^\/_spark/, '')), unless the backend routes have been updated to include the new prefix.
"/_spark/kv": {
salvador-barboza
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expected paths for the KV client changed with https://github.com/github/workbench-template/commit/c3b2da9f0e8ad8ca50133cc140729c8e398bcb8c#diff-6a3b01ba97829c9566ef2d8dc466ffcffb4bdac08706d3d6319e42e0aa6890dd but this didn't end up over in spark-template as well.