Skip to content

Fix up paths for KV to align with new values#6

Merged
jasonrclark merged 1 commit intomainfrom
jasonrclark/fix-kv
May 5, 2025
Merged

Fix up paths for KV to align with new values#6
jasonrclark merged 1 commit intomainfrom
jasonrclark/fix-kv

Conversation

@jasonrclark
Copy link
Member

Copilot AI review requested due to automatic review settings May 5, 2025 16:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the KV service endpoints to use the new /_spark prefix for both frontend environment variables and local development proxies.

  • Changed BASE_KV_SERVICE_URL from "/kv" to "/_spark/kv"
  • Updated dev server proxy paths for KV and LLM to include /_spark prefix
Comments suppressed due to low confidence (2)

vite.config.ts:44

  • Consider adding a corresponding BASE_LLM_SERVICE_URL definition for "/_spark/llm" so the LLM service URL is available via environment variables, mirroring the KV change.
BASE_KV_SERVICE_URL: JSON.stringify("/_spark/kv"),

vite.config.ts:74

  • Add a rewrite rule to strip the /_spark prefix when proxying to the backend (e.g., rewrite: path => path.replace(/^\/_spark/, '')), unless the backend routes have been updated to include the new prefix.
"/_spark/kv": {

@jasonrclark jasonrclark merged commit 6b438f5 into main May 5, 2025
4 checks passed
@jasonrclark jasonrclark deleted the jasonrclark/fix-kv branch May 5, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants