Update Deploy Script to Deploy Revisions#7
Merged
alexagillman merged 10 commits intomainfrom May 7, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for deploying specific revisions by introducing an environment-driven output directory and passing a revision flag to the deployment commands.
- Enable
build.outDirin Vite to respect theOUTPUT_DIRenvironment variable. - Refactor
deploy.shto accept a revision name, set a custom output directory, clean and build into it, and include a--revision-nameflag in the GitHub CLI calls.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vite.config.ts | Added build.outDir setting to use process.env.OUTPUT_DIR or dist. |
| deploy.sh | Modified to read a revision name, compute OUTPUT_DIR, clean/build into it, and add revision flags to gh commands. |
Comments suppressed due to low confidence (1)
deploy.sh:73
- [nitpick] The nested square brackets around the URL can be confusing in logs; consider removing the inner brackets so it reads
echo "[--URL-App=https://${DEPLOYED_URL}--]".
echo "[--URL-App=[https://${DEPLOYED_URL}]--]"
salvador-barboza
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Spark Readonly Preview] For item: https://github.com/github/spark/issues/1449. Support revision deploys