Skip to content

Update Deploy Script to Deploy Revisions#7

Merged
alexagillman merged 10 commits intomainfrom
dev/alexagillman/updateDeployScriptReadOnly
May 7, 2025
Merged

Update Deploy Script to Deploy Revisions#7
alexagillman merged 10 commits intomainfrom
dev/alexagillman/updateDeployScriptReadOnly

Conversation

@alexagillman
Copy link
Collaborator

@alexagillman alexagillman commented May 5, 2025

[Spark Readonly Preview] For item: https://github.com/github/spark/issues/1449. Support revision deploys

Copilot AI review requested due to automatic review settings May 5, 2025 17:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for deploying specific revisions by introducing an environment-driven output directory and passing a revision flag to the deployment commands.

  • Enable build.outDir in Vite to respect the OUTPUT_DIR environment variable.
  • Refactor deploy.sh to accept a revision name, set a custom output directory, clean and build into it, and include a --revision-name flag in the GitHub CLI calls.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
vite.config.ts Added build.outDir setting to use process.env.OUTPUT_DIR or dist.
deploy.sh Modified to read a revision name, compute OUTPUT_DIR, clean/build into it, and add revision flags to gh commands.
Comments suppressed due to low confidence (1)

deploy.sh:73

  • [nitpick] The nested square brackets around the URL can be confusing in logs; consider removing the inner brackets so it reads echo "[--URL-App=https://${DEPLOYED_URL}--]".
echo "[--URL-App=[https://${DEPLOYED_URL}]--]"

@alexagillman alexagillman merged commit 2ebe87e into main May 7, 2025
6 checks passed
@alexagillman alexagillman deleted the dev/alexagillman/updateDeployScriptReadOnly branch May 7, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants