-
Notifications
You must be signed in to change notification settings - Fork 3.8k
(feat): Enhancements to Spec Kit #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
Co-authored-by: Copilot <[email protected]>
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sync changes
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| import tomllib | ||
| pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml" | ||
| if pyproject_path.exists(): | ||
| with open(pyproject_path, "rb") as f: | ||
| data = tomllib.load(f) | ||
| cli_version = data.get("project", {}).get("version", "unknown") |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tomllib is only available in Python 3.11+. While the project requires Python >=3.11 according to pyproject.toml, the import should be wrapped in a try-except block since it's already inside an exception handler and a fallback version of "unknown" is acceptable.
| import tomllib | |
| pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml" | |
| if pyproject_path.exists(): | |
| with open(pyproject_path, "rb") as f: | |
| data = tomllib.load(f) | |
| cli_version = data.get("project", {}).get("version", "unknown") | |
| try: | |
| import tomllib | |
| except ImportError: | |
| # tomllib not available, fallback to "unknown" | |
| pass | |
| else: | |
| pyproject_path = Path(__file__).parent.parent.parent / "pyproject.toml" | |
| if pyproject_path.exists(): | |
| with open(pyproject_path, "rb") as f: | |
| data = tomllib.load(f) | |
| cli_version = data.get("project", {}).get("version", "unknown") |
| info_table.add_row("Template Version", template_version) | ||
| info_table.add_row("Released", release_date) | ||
| info_table.add_row("", "") | ||
| info_table.add_row("Python", f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}") |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The version string could be simplified using platform.python_version() which returns the same information in a cleaner way.
| info_table.add_row("Python", f"{sys.version_info.major}.{sys.version_info.minor}.{sys.version_info.micro}") | |
| info_table.add_row("Python", platform.python_version()) |
| $branches = git branch -a 2>$null | ||
| if ($LASTEXITCODE -eq 0) { | ||
| foreach ($branch in $branches) { | ||
| # Clean branch name: remove leading markers and remote prefixes |
Copilot
AI
Oct 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The regex pattern could be made more readable with a comment explaining that it removes Git's current branch marker (*), whitespace, and remote prefixes (e.g., 'remotes/origin/').
| # Clean branch name: remove leading markers and remote prefixes | |
| # Clean branch name: remove leading markers and remote prefixes | |
| # The following regex removes: | |
| # - Git's current branch marker ('*') and leading whitespace (e.g., '* main') | |
| # - Remote prefixes (e.g., 'remotes/origin/') |
|
in vscode insiders i have a warning saying "Chat modes have been renamed to agents. Please move this file to .github/agents/speckit.[prompt].agent.md". should you not put this inside the new designated folder and file from vscode ? |
|
I recommend that chatmodes, prompts should be named with prompt name first and .speckit after. So instead of speckit.plan it will be better to save as |
|
Hey guys, just two linting errors to fix pls. Seems the spec-it popularity is driving crazy release api rate limits and it's almost impossible to use |
|
I was just going to say the same thing @Nosafe did 😆 They've officially moved from |
| # Create prompt file with agent frontmatter | ||
| cat > "$prompt_file" <<EOF | ||
| --- | ||
| agent: ${basename} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any tools loaded anywhere—has this given you issues before? Every single time I forget to set a tool back in one of these agent files, it seems to stop everything... but as frequently as they're changing things, I've stopped trying to guess. 😆 Just calling out as something to verify before you merge.
|
|
||
| 1. For each task in the list, use the GitHub MCP server to create a new issue in the repository that is representative of the Git remote. | ||
|
|
||
| **UNDER NO CIRCUMSTANCES EVER CREATE ISSUES IN REPOSITORIES THAT DO NOT MATCH THE REMOTE URL** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought: Do you think it would be worth it to hard-code these checks in and not even load the prompt if the repo doesn't match? It's really more of a longer-term solution but might be worth a discussion. I'm not sure what that would even look like, tbh, but maybe worth a discussion at some point 🤷🏻♀️
Description
versioncommand. (specify --version flag not supported, returns error #486)Screenshots
Hand-offs
Version
References
Behavior notes