Skip to content

Phase 0b: Add PR provenance marker and tighten implement-worker merge relay #1731

Closed

Description

@bradygaster

Parent: #1729

Problem

Two defects in workflows/squad-implement-worker.md that the review gate depends on:

  1. No machine-readable provenance. A Squad-authored PR is identifiable only by the squad/implement-* head branch prefix. Branch names are mutable and a bot login is ambiguous once other automation opens PRs. The reviewer needs a durable marker.
  2. Merge relay is under-constrained. The pull_request: [closed] relay fires when merged == true and the head branch prefix matches, but does not verify the PR merged into the default branch. A merge into a scratch or stacked branch advances the epic as though the work had landed. The relay also drops aw_context, losing correlation between the merged PR run and the re-dispatch.

Scope

workflows/squad-implement-worker.md only.

Acceptance criteria

  • Worker PR bodies include a provenance marker, e.g. <!-- squad:implement issue=N run=<run_id> -->, emitted on every created PR.
  • Merge relay if condition additionally requires the PR base to equal the repository default branch.
  • Relay preserves aw_context through the re-dispatch.
  • Tests assert the marker format, the base-branch condition, and aw_context propagation.

Notes

The relay dispatches with target-ref: ${{ github.event.repository.default_branch }} because merged head branches may be deleted. That is correct and should not change. This issue constrains when the relay fires, not what ref it targets.

Activity

  1. added
    squadSquad triage inbox — Lead will assign to a member
    on Aug 17, 2026
  2. github-actions commented on Aug 17, 2026

    @github-actions
    Contributor

    📋 Assigned to EECOM (Core Dev)

    Issue: #1731 — Phase 0b: Add PR provenance marker and tighten implement-worker merge relay

    EECOM will pick this up in the next Copilot session.

    For Copilot coding agent: If enabled, this issue will be worked automatically.
    Otherwise, start a Copilot session and say:
    EECOM, work on issue #1731

  3. added
    triagedIssue has been triaged
    wave:1-nextWave 1 — immediate next sprint
    wave:3-laterWave 3 — backlog, future
    and removed
    wave:1-nextWave 1 — immediate next sprint
    on Aug 20, 2026
  4. bradygaster commented on Aug 23, 2026

    @bradygaster
    CollaboratorAuthor

    Procedures triage brief — Phase 0b

    Owner & rationale

    Owner: EECOM (squad:eecom). This lives in the implement-worker relay/provenance path and needs core workflow/runtime ownership rather than prompt-router ownership.

    Files in scope

    Verified existing paths:

    • workflows\squad-implement-worker.md
    • est\gh-aw-implement-workflow.test.ts

    Prompt-budget impact

    No direct workflows\squad.md impact: +0 KB to the router prompt. Router headroom remains 37,602 B unless a later phase spends it.

    Dependencies

    Verification bar

    A structural test must fail if the PR body lacks , if the relay can fire for a non-default base branch, or if �w_context is dropped. A substring-only smoke test is not a gate.

    Out of scope

    The reviewer workflow, required-check enforcement, remediation, and documentation.

    Session-stall guard

    Before starting: this repo has phantom CRLF diffs (#1793). If git status shows files modified that you did not touch, run git diff --ignore-cr-at-eol. If that output is empty, the diff is line-ending churn, not real edits — run git add --renormalize . and continue. Do not halt and ask for confirmation; halting on phantom diffs is the documented cause of stuck sessions in this repo.

  5. added a commit that references this issue on Aug 25, 2026
    8a98fdc
  6. added a commit that references this issue on Aug 25, 2026
    eaba923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    gh-awGitHub Agentic Workflows integrationgo:spec-readyReady for formal spec/proposalpriority:p1This sprintsquadSquad triage inbox — Lead will assign to a membertriagedIssue has been triagedtype:choreMaintenance, refactoring, cleanupwave:3-laterWave 3 — backlog, future

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions