Skip to content

[workshop-diagrams] Add theme-aware explanatory diagram for evals quality loop - #2965

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
diagram/27-evals-quality-loop-15f2ca90e47ec1df
Closed

github-actions[bot] wants to merge 1 commit into
mainfrom
diagram/27-evals-quality-loop-15f2ca90e47ec1df

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Added a new conceptual diagram to workshop/27-evaluate-workflow-quality.md explaining the evals quality loop: run workflow → ask binary questions → record YES/NO answers → compare across runs to catch regressions.

  • File changed: workshop/27-evaluate-workflow-quality.md
  • Type: New concept (no existing explanatory diagram was found for this step to migrate)
  • SVGs added:
    • workshop/images/27-evals-quality-loop-light.svg
    • workshop/images/27-evals-quality-loop-dark.svg

Why this helps learners

The step currently explains the evals: regression-detection workflow only in prose (run → inspect evals.jsonl → compare answers across runs → spot a YES→NO flip as a regression signal). This is a foundational mental model for the rest of the workshop's quality-gate content, reusable whenever evals are revisited, and fits cleanly into a single 4-stage diagram with a regression-alert callout.

Implementation notes

  • Diagram follows the repo's SVG style guide (1200×560 canvas, Primer semantic colors, unmodified Octicon paths for the workflow/checklist/clock icons, data-visual-kind/data-visual-id/data-node metadata).
  • Inserted using the canonical theme-aware <picture> block, light variant as <img> fallback with alt text.
  • Verified with scripts/check-svg-visual-language.js (0 violations) and rendered both light/dark variants via Playwright, confirming currentSrc resolves to the correct variant in each colorScheme and that all text stays within its boxes/chips at normal zoom.

Warning

Firewall blocked 5 domains

The following domains were blocked by the firewall during workflow execution:

  • accounts.google.com
  • android.clients.google.com
  • clients2.google.com
  • www.google.com
  • www.gstatic.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "accounts.google.com"
    - "android.clients.google.com"
    - "clients2.google.com"
    - "www.google.com"
    - "www.gstatic.com"

See Network Configuration for more information.

Generated by 🧠 Workshop Explanatory Diagram Generator · copilot · auto · 99.6 AIC · ⌖ 23.1 AIC · ⊞ 11.1K · ◷

  • expires on Sep 7, 2026, 2:40 AM UTC

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

This pull request was automatically closed because it expired on 2026-09-07T02:40:50.339Z.

Closed by Workflow

@github-actions github-actions Bot closed this Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants