Repository navigation
[workshop-diagrams] Add theme-aware explanatory diagram for evals quality loop - #2965
Closed
github-actions[bot] wants to merge 1 commit into
Closed
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
This pull request was automatically closed because it expired on 2026-09-07T02:40:50.339Z.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a new conceptual diagram to
workshop/27-evaluate-workflow-quality.mdexplaining the evals quality loop: run workflow → ask binary questions → record YES/NO answers → compare across runs to catch regressions.workshop/27-evaluate-workflow-quality.mdworkshop/images/27-evals-quality-loop-light.svgworkshop/images/27-evals-quality-loop-dark.svgWhy this helps learners
The step currently explains the
evals:regression-detection workflow only in prose (run → inspectevals.jsonl→ compare answers across runs → spot a YES→NO flip as a regression signal). This is a foundational mental model for the rest of the workshop's quality-gate content, reusable whenever evals are revisited, and fits cleanly into a single 4-stage diagram with a regression-alert callout.Implementation notes
data-visual-kind/data-visual-id/data-nodemetadata).<picture>block, light variant as<img>fallback with alt text.scripts/check-svg-visual-language.js(0 violations) and rendered both light/dark variants via Playwright, confirmingcurrentSrcresolves to the correct variant in eachcolorSchemeand that all text stays within its boxes/chips at normal zoom.Warning
Firewall blocked 5 domains
The following domains were blocked by the firewall during workflow execution:
accounts.google.comandroid.clients.google.comclients2.google.comwww.google.comwww.gstatic.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.